[compiler] Also UnpackIfThin in ReduceObjectPrototypeHasOwnProperty [v8/v8 : main]

[Jakob Linke (Gerrit)]

Attention needed from Darius Mercadier

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Darius Mercadier

Submit Requirements:

• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I51d1209e03b9c8b9b20fa3367681422eb8fa13b2

Gerrit-Change-Number: 6907708

Gerrit-PatchSet: 1

Gerrit-Owner: Jakob Linke <jgr...@chromium.org>

Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>

Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>

Gerrit-Comment-Date: Tue, 02 Sep 2025 11:35:00 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Darius Mercadier (Gerrit)]

Attention needed from Jakob Linke

Darius Mercadier voted and added 1 comment

Votes added by Darius Mercadier

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Darius Mercadier . resolved

LGTM thanks :)

Open in Gerrit

Related details

Attention is currently required from:

• Jakob Linke

Submit Requirements:

• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I51d1209e03b9c8b9b20fa3367681422eb8fa13b2

Gerrit-Change-Number: 6907708

Gerrit-PatchSet: 1

Gerrit-Owner: Jakob Linke <jgr...@chromium.org>

Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>

Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Jakob Linke <jgr...@chromium.org>

Gerrit-Comment-Date: Tue, 02 Sep 2025 11:45:22 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[chromeperf@appspot.gserviceaccount.com (Gerrit)]

Attention needed from Jakob Linke

Message from chrom...@appspot.gserviceaccount.com

📍 Job mac-m3-pro-perf/jetstream2 complete.

See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1619dd39910000

Open in Gerrit

Related details

Attention is currently required from:

• Jakob Linke

Submit Requirements:

• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I51d1209e03b9c8b9b20fa3367681422eb8fa13b2

Gerrit-Change-Number: 6907708

Gerrit-PatchSet: 1

Gerrit-Owner: Jakob Linke <jgr...@chromium.org>

Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>

Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Jakob Linke <jgr...@chromium.org>

Gerrit-Comment-Date: Tue, 02 Sep 2025 13:48:14 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Jakob Linke (Gerrit)]

Attention needed from Darius Mercadier

Jakob Linke voted and added 1 comment

Votes added by Jakob Linke

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Jakob Linke . resolved

PTAL again. I've updated the CL to match maglev behavior, i.e. only unpack when needed. The `descriptor_array.GetPropertyKey` unpacking was removed because GetPropertyKey already guarantees return_value.IsUniqueName.

Open in Gerrit

Related details

Attention is currently required from:

• Darius Mercadier

Submit Requirements:

• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I51d1209e03b9c8b9b20fa3367681422eb8fa13b2

Gerrit-Change-Number: 6907708

Gerrit-PatchSet: 3

Gerrit-Owner: Jakob Linke <jgr...@chromium.org>

Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>

Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>

Gerrit-Comment-Date: Fri, 05 Sep 2025 06:16:04 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Darius Mercadier (Gerrit)]

Attention needed from Jakob Linke

Darius Mercadier voted and added 1 comment

Votes added by Darius Mercadier

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Darius Mercadier . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Jakob Linke

Submit Requirements:

• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I51d1209e03b9c8b9b20fa3367681422eb8fa13b2

Gerrit-Change-Number: 6907708

Gerrit-PatchSet: 3

Gerrit-Owner: Jakob Linke <jgr...@chromium.org>

Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>

Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chrom...@appspot.gserviceaccount.com <chrom...@appspot.gserviceaccount.com>

Gerrit-Attention: Jakob Linke <jgr...@chromium.org>

Gerrit-Comment-Date: Fri, 05 Sep 2025 06:34:33 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes