Commit-Queue | +1 |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +1 |
lgtm %
if ((true) || !v8_flags.reuse_scope_infos) return true;
Just to check my understanding: It's intentional that this func now always returns true, an in the future it will always return true if the --reuse-scope-infos is not enabled?
compiler::OptionalScopeInfoRef scope_info =
graph->TryGetScopeInfo(context);
This could be moved out of the loop?
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
😿 Job mac-m1_mini_2020-perf/jetstream2 failed.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/17030785510000
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit-Queue | +2 |
if ((true) || !v8_flags.reuse_scope_infos) return true;
Just to check my understanding: It's intentional that this func now always returns true, an in the future it will always return true if the --reuse-scope-infos is not enabled?
Yeah, I just copied and pasted this function. There is a TODO there, I didn't want to change. But you're right, the logic is disabled for now. We should try to re-enable it in the future.
compiler::OptionalScopeInfoRef scope_info =
graph->TryGetScopeInfo(context);
This could be moved out of the loop?
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/maglev/maglev-known-node-aspects.cc
Insertions: 1, Deletions: 2.
@@ -468,9 +468,8 @@
graph->broker()->local_isolate(), context);
}
if (may_have_aliasing_contexts() == ContextSlotLoadsAlias::kYes) {
+ compiler::OptionalScopeInfoRef scope_info = graph->TryGetScopeInfo(context);
for (auto& cache : loaded_context_slots_) {
- compiler::OptionalScopeInfoRef scope_info =
- graph->TryGetScopeInfo(context);
int cached_offset = std::get<int>(cache.first);
ValueNode* cached_context = std::get<ValueNode*>(cache.first);
if (cached_offset == offset && cached_context != context) {
```
[maglev] Refactor context aliasing logic
It moves the context aliasing logic to the KNA, so
that it can be used by other compiler passes.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |