[unittests] Increase time threshold for ElapsedTimer.StartStop [v8/v8 : main]

0 views
Skip to first unread message

Camillo Bruni (Gerrit)

unread,
Dec 15, 2025, 10:50:29 AM (22 hours ago) Dec 15
to Marja Hölttä, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Marja Hölttä

Camillo Bruni added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Camillo Bruni . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Marja Hölttä
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I53452907e3266f19cf0b9f985abec75af7583214
Gerrit-Change-Number: 7261258
Gerrit-PatchSet: 1
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Attention: Marja Hölttä <ma...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 15:50:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Marja Hölttä (Gerrit)

unread,
1:52 AM (7 hours ago) 1:52 AM
to Camillo Bruni, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Camillo Bruni

Marja Hölttä voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Camillo Bruni
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I53452907e3266f19cf0b9f985abec75af7583214
Gerrit-Change-Number: 7261258
Gerrit-PatchSet: 1
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Attention: Camillo Bruni <cbr...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Dec 2025 06:52:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Camillo Bruni (Gerrit)

unread,
5:51 AM (3 hours ago) 5:51 AM
to Marja Hölttä, V8 LUCI CQ, v8-re...@googlegroups.com

Camillo Bruni voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I53452907e3266f19cf0b9f985abec75af7583214
Gerrit-Change-Number: 7261258
Gerrit-PatchSet: 1
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Dec 2025 10:51:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
5:52 AM (3 hours ago) 5:52 AM
to Camillo Bruni, Marja Hölttä, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[unittests] Increase time threshold for ElapsedTimer.StartStop

Hopefully this helps reducing flaky runs on windows.
Fixed: 380407266
Change-Id: I53452907e3266f19cf0b9f985abec75af7583214
Reviewed-by: Marja Hölttä <ma...@chromium.org>
Commit-Queue: Camillo Bruni <cbr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104338}
Files:
  • M test/unittests/base/platform/time-unittest.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Marja Hölttä
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I53452907e3266f19cf0b9f985abec75af7583214
Gerrit-Change-Number: 7261258
Gerrit-PatchSet: 2
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages