[test] Add regression test [v8/v8 : main]

Victor Gomes (Gerrit)

unread,

Jul 4, 2023, 6:24:58 AM7/4/23

to Michael Achenbach, almuthan...@chromium.org, v8-re...@googlegroups.com

Attention is currently required from: Michael Achenbach.

Victor Gomes would like Michael Achenbach to review this change.

[test] Add regression test

Bug: chromium:1459681
Change-Id: Ic46e3c51d36e6f33cff346ffe7c84c89f6814497
---
A test/mjsunit/maglev/regress-1459681.js
1 file changed, 13 insertions(+), 0 deletions(-)

diff --git a/test/mjsunit/maglev/regress-1459681.js b/test/mjsunit/maglev/regress-1459681.js
new file mode 100644
index 0000000..edee4ad
--- /dev/null
+++ b/test/mjsunit/maglev/regress-1459681.js
@@ -0,0 +1,13 @@
+// Copyright 2023 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// Flags: --allow-natives-syntax --maglev
+
+function foo(x) {
+  return x >> 32; // We should not shift anything here!
+}
+%PrepareFunctionForOptimization(foo);
+assertEquals(42, foo(42));
+%OptimizeMaglevOnNextCall(foo);
+assertEquals(42, foo(42));

To view, visit change 4661334. To unsubscribe, or for help writing mail filters, visit settings.

Victor Gomes (Gerrit)

unread,

Jul 4, 2023, 6:25:00 AM7/4/23

to almuthan...@chromium.org, v8-re...@googlegroups.com, Michael Achenbach

Attention is currently required from: Michael Achenbach.

Patch set 1:Auto-Submit +1Commit-Queue +1

View Change

1 comment:

Patchset:
- Patch Set #1:
  PTAL!

To view, visit change 4661334. To unsubscribe, or for help writing mail filters, visit settings.

Michael Achenbach (Gerrit)

unread,

Jul 4, 2023, 6:50:59 AM7/4/23

to Victor Gomes, almuthan...@chromium.org, v8-re...@googlegroups.com, V8 LUCI CQ

Attention is currently required from: Victor Gomes.

Patch set 1:Code-Review +1Commit-Queue +2

View Change

To view, visit change 4661334. To unsubscribe, or for help writing mail filters, visit settings.

V8 LUCI CQ (Gerrit)

unread,

Jul 4, 2023, 7:15:30 AM7/4/23

to Victor Gomes, almuthan...@chromium.org, v8-re...@googlegroups.com, Michael Achenbach

V8 LUCI CQ submitted this change.

View Change

Approvals:
  Michael Achenbach: Looks good to me; Commit
  Victor Gomes: Send CL to CQ automatically after approval; Dry run

[test] Add regression test

Bug: chromium:1459681
Change-Id: Ic46e3c51d36e6f33cff346ffe7c84c89f6814497

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4661334
Auto-Submit: Victor Gomes <victo...@chromium.org>
Commit-Queue: Victor Gomes <victo...@chromium.org>
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Michael Achenbach <mache...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#88643}


---
A test/mjsunit/maglev/regress-1459681.js
1 file changed, 13 insertions(+), 0 deletions(-)

diff --git a/test/mjsunit/maglev/regress-1459681.js b/test/mjsunit/maglev/regress-1459681.js
new file mode 100644
index 0000000..edee4ad
--- /dev/null
+++ b/test/mjsunit/maglev/regress-1459681.js
@@ -0,0 +1,13 @@
+// Copyright 2023 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// Flags: --allow-natives-syntax --maglev
+
+function foo(x) {
+  return x >> 32; // We should not shift anything here!
+}
+%PrepareFunctionForOptimization(foo);
+assertEquals(42, foo(42));
+%OptimizeMaglevOnNextCall(foo);
+assertEquals(42, foo(42));

To view, visit change 4661334. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward