[wasm][liftoff][loong64] Fix LoadTaggedPointer [v8/v8 : main]

0 views
Skip to first unread message

Jakob Kummerow (Gerrit)

unread,
6:22 AM (5 hours ago) 6:22 AM
to Liu Yu, Jakob Kummerow, Zhao Jiazhong, AyeAye, v8-loongar...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Liu Yu and Zhao Jiazhong

Jakob Kummerow voted and added 1 comment

Votes added by Jakob Kummerow

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Jakob Kummerow . resolved

rubberstamp LGTM (no actual review)

Open in Gerrit

Related details

Attention is currently required from:
  • Liu Yu
  • Zhao Jiazhong
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I6f0cce15b0d7bebb7e97f10c370a43a6ad0a9d1c
Gerrit-Change-Number: 7078270
Gerrit-PatchSet: 2
Gerrit-Owner: Liu Yu <li...@loongson.cn>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Zhao Jiazhong <zhaojia...@loongson.cn>
Gerrit-Attention: Zhao Jiazhong <zhaojia...@loongson.cn>
Gerrit-Attention: Liu Yu <li...@loongson.cn>
Gerrit-Comment-Date: Thu, 23 Oct 2025 10:22:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Zhao Jiazhong (Gerrit)

unread,
7:01 AM (4 hours ago) 7:01 AM
to Liu Yu, Jakob Kummerow, AyeAye, v8-loongar...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Liu Yu

Zhao Jiazhong voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Liu Yu
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I6f0cce15b0d7bebb7e97f10c370a43a6ad0a9d1c
Gerrit-Change-Number: 7078270
Gerrit-PatchSet: 2
Gerrit-Owner: Liu Yu <li...@loongson.cn>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Zhao Jiazhong <zhaojia...@loongson.cn>
Gerrit-Attention: Liu Yu <li...@loongson.cn>
Gerrit-Comment-Date: Thu, 23 Oct 2025 11:01:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
7:41 AM (4 hours ago) 7:41 AM
to Liu Yu, Zhao Jiazhong, Jakob Kummerow, AyeAye, v8-loongar...@chromium.org, v8-re...@googlegroups.com, was...@google.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[wasm][liftoff][loong64] Fix LoadTaggedPointer

Port commit 3f04ab3849936177a4cb85f53d82358bf755a440

The previous way to compute the protected_load_pc didn't account for
the possibility of TrampolinePool getting emitted.
Change-Id: I6f0cce15b0d7bebb7e97f10c370a43a6ad0a9d1c
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Reviewed-by: Zhao Jiazhong <zhaojia...@loongson.cn>
Commit-Queue: Zhao Jiazhong <zhaojia...@loongson.cn>
Cr-Commit-Position: refs/heads/main@{#103311}
Files:
  • M src/wasm/baseline/loong64/liftoff-assembler-loong64-inl.h
Change size: S
Delta: 1 file changed, 26 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Zhao Jiazhong, +1 by Jakob Kummerow
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I6f0cce15b0d7bebb7e97f10c370a43a6ad0a9d1c
Gerrit-Change-Number: 7078270
Gerrit-PatchSet: 3
Gerrit-Owner: Liu Yu <li...@loongson.cn>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages