[heap] Gate DescriptorArray trimming behind a flag [v8/v8 : main]
Omer Katz (Gerrit)
Omer Katz added 1 comment![]( "Open in Gerrit")
Related details
- Patrick Thier
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Patrick Thier added 4 comments![]( "Open in Gerrit")
Sorry I didn't realize this immediately when we briefly talked at lunch, but with the requirement to clear entries this will unfortunately not solve the problem 😞
This will just turn a potential OOB read into a type confusion: We expect the keys to be `Name`s.
Another option could be to use holes instead of undefines. With Leszeks recent changes (having an unmapped page after the hole map), we would crash and therefore prevent any issues. I haven't fully thought this through yet, but wanted to post my reply before going home.
during GCs with stack. These flags are meant ot allow experimenting```suggestion
during GCs with stack. These flags are meant to allow experimenting
```
HandleDeadArraySlotsCallback handle_dead_array_slots) {```suggestion
const HandleDeadArraySlotsCallback&& handle_dead_array_slots) {
```
Probably doesn't fit into 80 columns anymore and needs some extra formatting.
DCHECK(descriptors->number_of_all_descriptors() ==
number_of_own_descriptors);```suggestion
DCHECK_EQ(descriptors->number_of_all_descriptors(),
number_of_own_descriptors);
```
Related details
- Omer Katz
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Omer Katz (Gerrit)
Omer Katz added 4 comments![]( "Open in Gerrit")
Sorry I didn't realize this immediately when we briefly talked at lunch, but with the requirement to clear entries this will unfortunately not solve the problem 😞
This will just turn a potential OOB read into a type confusion: We expect the keys to be `Name`s.
Another option could be to use holes instead of undefines. With Leszeks recent changes (having an unmapped page after the hole map), we would crash and therefore prevent any issues. I haven't fully thought this through yet, but wanted to post my reply before going home.
Good point. I need to think this through a bit more. Thanks!
during GCs with stack. These flags are meant ot allow experimenting```suggestion
during GCs with stack. These flags are meant to allow experimenting
```
Done
HandleDeadArraySlotsCallback handle_dead_array_slots) {```suggestion
const HandleDeadArraySlotsCallback&& handle_dead_array_slots) {
```Probably doesn't fit into 80 columns anymore and needs some extra formatting.
Done
DCHECK(descriptors->number_of_all_descriptors() ==
number_of_own_descriptors);Omer Katz```suggestion
DCHECK_EQ(descriptors->number_of_all_descriptors(),
number_of_own_descriptors);
```
Done
Related details
- Patrick Thier
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |