[execution] Fix DCHECK in VisitSpillSlot for parallel root scanning [v8/v8 : main]
0 views
Skip to first unread message
Dominik Inführ (Gerrit)
1:42 AM (7 hours ago) 1:42 AM
to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow
Dominik Inführ added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Dominik Inführ . resolved
PTAL since you already know the issue very well. Sorry that you had to investigate my issue!
Related details
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
4:51 AM (4 hours ago) 4:51 AM
to Dominik Inführ, Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Dominik Inführ
Jakob Kummerow voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dominik Inführ
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominik Inführ (Gerrit)
4:58 AM (4 hours ago) 4:58 AM
to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com
Dominik Inführ voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dominik Inführ
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
5:00 AM (4 hours ago) 5:00 AM
to Dominik Inführ, Jakob Kummerow, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[execution] Fix DCHECK in VisitSpillSlot for parallel root scanning
Starting with https://crrev.com/c/7534962 we iterate roots
concurrently to scavenging GC threads. This CL fixes a DCHECK in
VisitSpillSlot() which might fail with the right timing.
The issue here was that we had a double-load of the map word and
assumed that the map word remained the same. This was perfectly fine
so far but in the presence of parallel scavenging tasks can result
in DCHECK failures because these threads could relocate that object
in-between those two loads.
Bug: 483623027
Change-Id: Ibb250f5ea216f0d057f070138b93a41469095d68
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Dominik Inführ <dinf...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105404}
Files:
- M src/execution/frames.cc
Change size: XS
Delta: 1 file changed, 7 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Kummerow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages