[wasm][cleanup] Remove last remaining remnants of asm.js [v8/v8 : main]
0 views
Skip to first unread message
Clemens Backes (Gerrit)
Jul 23, 2026, 9:36:01 AM (2 days ago) Jul 23
to Michael Achenbach, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Jakob Kummerow, Marco Vitale, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Jakob Kummerow and Michael Achenbach
Clemens Backes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Clemens Backes . resolved
PTAL, +Michael for `gni/` (a comment-only change)
Related details
Attention is currently required from:
- Jakob Kummerow
- Michael Achenbach
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
Jul 23, 2026, 9:53:34 AM (2 days ago) Jul 23
to Clemens Backes, Jakob Kummerow, Michael Achenbach, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Marco Vitale, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Clemens Backes and Michael Achenbach
Jakob Kummerow voted and added 3 comments![]( "Open in Gerrit")
Votes added by Jakob Kummerow
| Code-Review | +1 |
3 comments
Patchset-level comments
Attention is currently required from:
- Clemens Backes
- Michael Achenbach
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Jul 23, 2026, 10:01:16 AM (2 days ago) Jul 23
to Jakob Kummerow, Michael Achenbach, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Marco Vitale, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Michael Achenbach
Clemens Backes added 2 comments![]( "Open in Gerrit")
File test/common/wasm/fuzzer-common.cc
Line 525, Patchset 1:
{}) // no imports & memoryJakob Kummerow . resolved
Clemens Backesmissed one :)
Done
Related details
Attention is currently required from:
- Michael Achenbach
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Jul 24, 2026, 2:59:44 AM (yesterday) Jul 24
to Clemens Backes, Jakob Kummerow, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Marco Vitale, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Clemens Backes
Michael Achenbach voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Jul 24, 2026, 4:21:06 AM (yesterday) Jul 24
to Michael Achenbach, Jakob Kummerow, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Marco Vitale, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Clemens Backes voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 24, 2026, 4:23:18 AM (yesterday) Jul 24
to Clemens Backes, Michael Achenbach, Jakob Kummerow, Marco Vitale, dmercadi...@chromium.org, v8-re...@googlegroups.com, was...@google.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasm][cleanup] Remove last remaining remnants of asm.js
Clean up all remaining legacy asm.js-specific code paths, unused
parameters, dead enum/bit fields, obsolete tests, and inaccurate
comments across the V8 codebase to improve overall maintainability
and structure.
This finalizes decommissioning the remnants of legacy asm.js support:
- Removed WasmElemSegment::FunctionIndexingMode enum and indexing_mode
parameters / field from WasmModuleBuilder.
Updated three calling tests to omit the 4th argument.
- Removed unused memory / asmjs_memory_buffer parameter and member in
InstanceBuilder and InstantiateToInstanceObject.
- Removed unused memory parameter in WasmEngine::SyncInstantiate.
Omitted the null JSArrayBuffer handle across all its call sites
(including src/wasm/wasm-js.cc, src/runtime/runtime-test-wasm.cc,
src/wasm/c-api.cc, and all 10 test and fuzzer files).
- Reclaimed exactly 1 bit in JSArrayBuffer flags by removing
IsAsmJsMemoryBit (realigning subsequent fields, and decrementing
kFlagCount from 7 to 6).
- Removed is_asm_js_memory from JSArrayBufferFlags in Torque.
- Deleted test/mjsunit/sandbox/regress-430960844.js and
test/mjsunit/sandbox/regress-502356099.js as they are obsolete
sandbox regression tests that specifically rely on asm.js being
compiled to Wasm to trigger stack/frame corruption.
- Removed obsolete asm.js error location comment and source position
assignment from src/compiler/turboshaft/wasm-wrappers-inl.h.
- Cleaned up leftover comments referencing asm.js across gni/v8.gni,
src/codegen/compiler.cc, src/objects/shared-function-info-inl.h,
src/objects/call-site-info.h, src/wasm/wasm-code-manager.cc, and
src/wasm/wasm-engine.cc.
- Removed stale src/asmjs/ reference from agent infrastructure
(agents/prompts/common.md, agents/skills/v8-structure/SKILL.md).
TAG=agy
R=jkum...@chromium.org
Bug: 510487707
Change-Id: Idfe673b2a8eca3caa836a0fa40afcc5327a53159
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108860}
Files:
- M agents/prompts/common.md
- M agents/skills/v8-structure/SKILL.md
- M gni/v8.gni
- M src/codegen/compiler.cc
- M src/compiler/turboshaft/wasm-wrappers-inl.h
- M src/objects/call-site-info.h
- M src/objects/js-array-buffer.h
- M src/objects/js-array-buffer.tq
- M src/objects/shared-function-info-inl.h
- M src/runtime/runtime-test-wasm.cc
- M src/wasm/c-api.cc
- M src/wasm/module-instantiate.cc
- M src/wasm/module-instantiate.h
- M src/wasm/wasm-code-manager.cc
- M src/wasm/wasm-engine.cc
- M src/wasm/wasm-engine.h
- M src/wasm/wasm-js.cc
- M src/wasm/wasm-module-builder.cc
- M src/wasm/wasm-module-builder.h
- M test/cctest/wasm/test-run-wasm-wrappers.cc
- M test/cctest/wasm/test-streaming-compilation.cc
- M test/cctest/wasm/test-wasm-serialization.cc
- M test/cctest/wasm/test-wasm-shared-engine.cc
- M test/common/wasm/fuzzer-common.cc
- M test/common/wasm/wasm-module-runner.cc
- M test/fuzzer/wasm/deopt.cc
- M test/fuzzer/wasm/init-expr.cc
- M test/fuzzer/wasm/interpreter/interpreter-fuzzer-common.cc
- M test/fuzzer/wasm/interpreter/interpreter-init-expr.cc
- M test/mjsunit/mjsunit.status
- D test/mjsunit/sandbox/regress-430960844.js
- D test/mjsunit/sandbox/regress-502356099.js
- M test/unittests/wasm/wasm-tracing-unittest.cc
- M test/wasm-api-tests/table.cc
Change size: L
Delta: 34 files changed, 70 insertions(+), 267 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Kummerow, +1 by Michael Achenbach
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages