[maglev][arm64] Ensure we zero-extend in Int32Multiply [v8/v8 : main]

1 view
Skip to first unread message

Victor Gomes (Gerrit)

unread,
Dec 9, 2025, 9:17:55 AM12/9/25
to Darius Mercadier, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier

Victor Gomes voted and added 1 comment

Votes added by Victor Gomes

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Victor Gomes . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Darius Mercadier
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ie75222393743a8beeb99f9382dc6d345b8f62604
Gerrit-Change-Number: 7241729
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:17:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Darius Mercadier (Gerrit)

unread,
Dec 9, 2025, 9:29:26 AM12/9/25
to Victor Gomes, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes

Darius Mercadier voted and added 1 comment

Votes added by Darius Mercadier

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Darius Mercadier . resolved

LGTM, but as discussed offline, we should think about a more permanent solution to avoid this happening elsewhere as well

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Gomes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ie75222393743a8beeb99f9382dc6d345b8f62604
Gerrit-Change-Number: 7241729
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:29:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Victor Gomes (Gerrit)

unread,
Dec 9, 2025, 9:31:07 AM12/9/25
to Darius Mercadier, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Victor Gomes voted and added 2 comments

Votes added by Victor Gomes

Commit-Queue+2

2 comments

Patchset-level comments
Victor Gomes . resolved

Thanks!

Darius Mercadier . resolved

LGTM, but as discussed offline, we should think about a more permanent solution to avoid this happening elsewhere as well

Victor Gomes

Yeah, I think we should have a __ ZeroExtend(register) macro. Let's do it in a follow up.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ie75222393743a8beeb99f9382dc6d345b8f62604
Gerrit-Change-Number: 7241729
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:31:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Darius Mercadier <dmerc...@chromium.org>
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Dec 9, 2025, 10:10:23 AM12/9/25
to Victor Gomes, Darius Mercadier, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
[maglev][arm64] Ensure we zero-extend in Int32Multiply
Fixed: 466786677
Change-Id: Ie75222393743a8beeb99f9382dc6d345b8f62604
Auto-Submit: Victor Gomes <victo...@chromium.org>
Commit-Queue: Darius Mercadier <dmerc...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104206}
Files:
  • M src/maglev/arm64/maglev-ir-arm64.cc
  • A test/mjsunit/maglev/regress-466786677.js
Change size: S
Delta: 2 files changed, 25 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Darius Mercadier
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ie75222393743a8beeb99f9382dc6d345b8f62604
Gerrit-Change-Number: 7241729
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages