[maglev][arm64] Ensure we zero-extend in Int32Multiply [v8/v8 : main]
1 view
Skip to first unread message
Victor Gomes (Gerrit)
Dec 9, 2025, 9:17:55 AM12/9/25
to Darius Mercadier, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Dec 9, 2025, 9:29:26 AM12/9/25
to Victor Gomes, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Darius Mercadier . resolved
LGTM, but as discussed offline, we should think about a more permanent solution to avoid this happening elsewhere as well
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Dec 9, 2025, 9:31:07 AM12/9/25
to Darius Mercadier, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Victor Gomes voted and added 2 comments![]( "Open in Gerrit")
Votes added by Victor Gomes
| Commit-Queue | +2 |
2 comments
Patchset-level comments
Victor Gomes . resolved
Thanks!
Darius Mercadier . resolved
LGTM, but as discussed offline, we should think about a more permanent solution to avoid this happening elsewhere as well
Victor Gomes
Yeah, I think we should have a __ ZeroExtend(register) macro. Let's do it in a follow up.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 9, 2025, 10:10:23 AM12/9/25
to Victor Gomes, Darius Mercadier, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[maglev][arm64] Ensure we zero-extend in Int32Multiply
Fixed: 466786677
Change-Id: Ie75222393743a8beeb99f9382dc6d345b8f62604
Auto-Submit: Victor Gomes <victo...@chromium.org>
Commit-Queue: Darius Mercadier <dmerc...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104206}
Files:
- M src/maglev/arm64/maglev-ir-arm64.cc
- A test/mjsunit/maglev/regress-466786677.js
Change size: S
Delta: 2 files changed, 25 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages