[wasm] Introduce a separate mutex for signature storage [v8/v8 : main]
0 views
Skip to first unread message
Clemens Backes (Gerrit)
Feb 23, 2026, 11:53:24 AM (21 hours ago) Feb 23
to V8 LUCI CQ, Jakob Kummerow, v8-re...@googlegroups.com, was...@google.com
Attention needed from Jakob Kummerow
Clemens Backes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Clemens Backes
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
Feb 23, 2026, 12:18:48 PM (21 hours ago) Feb 23
to Clemens Backes, Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Clemens Backes
Jakob Kummerow voted and added 2 comments![]( "Open in Gerrit")
Votes added by Jakob Kummerow
| Code-Review | +1 |
2 comments
Patchset-level comments
File test/mjsunit/regress/wasm/regress-484405356.js
Line 5, Patchset 3 (Latest):
// Flags: --expose-gc --allow-natives-syntax --dump-countersJakob Kummerow . unresolved
Is that needed for the repro?
Related details
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
3:38 AM (5 hours ago) 3:38 AM
to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Clemens Backes added 1 comment![]( "Open in Gerrit")
File test/mjsunit/regress/wasm/regress-484405356.js
Line 5, Patchset 3 (Latest):
// Flags: --expose-gc --allow-natives-syntax --dump-countersJakob Kummerow . resolved
Is that needed for the repro?
Clemens Backes
Yes, it's needed. I don't really know why, the data race is between tier up and GC. But without `--dump-counters` it does not reproduce.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
4:37 AM (4 hours ago) 4:37 AM
to Jakob Kummerow, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Clemens Backes voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
4:40 AM (4 hours ago) 4:40 AM
to Clemens Backes, Jakob Kummerow, v8-re...@googlegroups.com, was...@google.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasm] Introduce a separate mutex for signature storage
This avoids lock order inversions and is the much simpler design, at the
cost of increasing the module size by another 16 bytes.
Long-term we could think about merging back together the different
mutexes stored in the `WasmModule`.
R=jkum...@chromium.org
Bug: 484405356
Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_dbg
Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel
Change-Id: Ie7e3a55569055609f36c78bf2a2efc111a95e2cb
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105403}
Files:
- M src/wasm/module-instantiate.cc
- M src/wasm/wasm-code-manager.cc
- M src/wasm/wasm-code-manager.h
- M src/wasm/wasm-module.cc
- M src/wasm/wasm-module.h
- A test/mjsunit/regress/wasm/regress-484405356.js
Change size: M
Delta: 6 files changed, 52 insertions(+), 39 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Kummerow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages