[test] Add two old regression tests [v8/v8 : main]

0 views
Skip to first unread message

Jakob Kummerow (Gerrit)

unread,
8:40 AM (11 hours ago) 8:40 AM
to Jakob Kummerow, Clemens Backes, v8-re...@googlegroups.com
Attention needed from Clemens Backes

Jakob Kummerow voted and added 1 comment

Votes added by Jakob Kummerow

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jakob Kummerow . resolved

Had these sitting on my hard drive for a long time by now.
IIRC you asked for better test coverage for compile-time imports back in the day, and I said I'd write a test, and I did, but never got around to uploading it. Well, at least it's been running every time I ran tests locally 😊
PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I9d4313254d7faa63b4bb462df5367da0ac3e27f8
Gerrit-Change-Number: 7795748
Gerrit-PatchSet: 1
Gerrit-Owner: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 12:40:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Clemens Backes (Gerrit)

unread,
10:41 AM (9 hours ago) 10:41 AM
to Jakob Kummerow, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow

Clemens Backes voted and added 1 comment

Votes added by Clemens Backes

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Jakob Kummerow . resolved

Had these sitting on my hard drive for a long time by now.
IIRC you asked for better test coverage for compile-time imports back in the day, and I said I'd write a test, and I did, but never got around to uploading it. Well, at least it's been running every time I ran tests locally 😊
PTAL.

Clemens Backes

Wow, that's pretty old indeed. LGTM.

Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Kummerow
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I9d4313254d7faa63b4bb462df5367da0ac3e27f8
Gerrit-Change-Number: 7795748
Gerrit-PatchSet: 1
Gerrit-Owner: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Attention: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 14:41:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jakob Kummerow <jkum...@chromium.org>
satisfied_requirement
open
diffy

v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
10:43 AM (9 hours ago) 10:43 AM
to Jakob Kummerow, Clemens Backes, v8-re...@googlegroups.com

v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[test] Add two old regression tests
Bug: 391907159
Change-Id: I9d4313254d7faa63b4bb462df5367da0ac3e27f8
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Clemens Backes <clem...@chromium.org>
Auto-Submit: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#106893}
Files:
  • A test/mjsunit/regress/wasm/regress-391907159.js
  • A test/mjsunit/wasm/compile-time-builtins.js
Change size: M
Delta: 2 files changed, 219 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Clemens Backes
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I9d4313254d7faa63b4bb462df5367da0ac3e27f8
Gerrit-Change-Number: 7795748
Gerrit-PatchSet: 2
Gerrit-Owner: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages