[wasm] Fix inlining-aware stack walking and clean up WasmFrame [v8/v8 : main]

0 views
Skip to first unread message

Clemens Backes (Gerrit)

unread,
8:46 AM (13 hours ago) 8:46 AM
to Jakob Kummerow, Simon Zünd, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Matthias Liedtke, devtools-...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Jakob Kummerow, Matthias Liedtke and Simon Zünd

Clemens Backes added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Clemens Backes . resolved

Matthias, can you do the main review?
+Jakob for src/execution
+Simon for src/debug

Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Kummerow
  • Matthias Liedtke
  • Simon Zünd
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I14860b227999545dc88f5d96dd420d1c6c2128f3
Gerrit-Change-Number: 7845117
Gerrit-PatchSet: 3
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Attention: Simon Zünd <szu...@chromium.org>
Gerrit-Attention: Jakob Kummerow <jkum...@chromium.org>
Gerrit-Comment-Date: Tue, 19 May 2026 12:46:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Simon Zünd (Gerrit)

unread,
8:52 AM (12 hours ago) 8:52 AM
to Clemens Backes, Jakob Kummerow, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Matthias Liedtke, devtools-...@chromium.org, v8-re...@googlegroups.com, was...@google.com
Attention needed from Clemens Backes, Jakob Kummerow and Matthias Liedtke

Simon Zünd voted and added 2 comments

Votes added by Simon Zünd

Code-Review+1

2 comments

Patchset-level comments
Simon Zünd . resolved

lgtm with question

File src/debug/debug-stack-trace-iterator.cc
Line 176, Patchset 3 (Latest): uint32_t func_index = FrameSummary::Get(frame, inlined_frame_index_)
Simon Zünd . unresolved

question: Is `inlined_frame_index_` updated correctly for inlined wasm functions? I forgot how iterator_ is implemented under the hood.

Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
  • Jakob Kummerow
  • Matthias Liedtke
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I14860b227999545dc88f5d96dd420d1c6c2128f3
    Gerrit-Change-Number: 7845117
    Gerrit-PatchSet: 3
    Gerrit-Owner: Clemens Backes <clem...@chromium.org>
    Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
    Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
    Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
    Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
    Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>
    Gerrit-Attention: Clemens Backes <clem...@chromium.org>
    Gerrit-Attention: Jakob Kummerow <jkum...@chromium.org>
    Gerrit-Comment-Date: Tue, 19 May 2026 12:52:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Jakob Kummerow (Gerrit)

    unread,
    10:08 AM (11 hours ago) 10:08 AM
    to Clemens Backes, Jakob Kummerow, Simon Zünd, v8-s...@luci-project-accounts.iam.gserviceaccount.com, Matthias Liedtke, devtools-...@chromium.org, v8-re...@googlegroups.com, was...@google.com
    Attention needed from Clemens Backes and Matthias Liedtke

    Jakob Kummerow voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Clemens Backes
    • Matthias Liedtke
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I14860b227999545dc88f5d96dd420d1c6c2128f3
    Gerrit-Change-Number: 7845117
    Gerrit-PatchSet: 3
    Gerrit-Owner: Clemens Backes <clem...@chromium.org>
    Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
    Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
    Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
    Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
    Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>
    Gerrit-Attention: Clemens Backes <clem...@chromium.org>
    Gerrit-Comment-Date: Tue, 19 May 2026 14:08:42 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Matthias Liedtke (Gerrit)

    unread,
    10:54 AM (10 hours ago) 10:54 AM
    to Clemens Backes, Jakob Kummerow, Simon Zünd, v8-s...@luci-project-accounts.iam.gserviceaccount.com, devtools-...@chromium.org, v8-re...@googlegroups.com, was...@google.com
    Attention needed from Clemens Backes

    Matthias Liedtke added 2 comments

    Patchset-level comments
    Matthias Liedtke . unresolved

    This touches a decent amount of debugging-related code. I don't know what the correct behavior should be in these cases, I don't think we ever cared what happens when debugging / inspecting optimized code?

    File src/execution/frames.h
    Line 1386, Patchset 3 (Latest): // Returns the byte position in the module of the innermost inlined frame.
    // This method is handle-free; use FrameSummary for more comprehensive
    // information.
    Matthias Liedtke . unresolved

    Shouldn't it return the position() of the outermost function?
    If I have multiple functions inlined into another function `a`, then `wasm_code` returns the optimized code for `a`. Shouldn't `position()` then return a position within `a` and not a position of some arbitrary other function that was inlined?

    That would also be aligned with your changes in `WasmFrame::Print` which prints the outer-most function, not the innermost.

    Or is that behavior chosen this way because it probably aligns with the previous behavior of this function?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Clemens Backes
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I14860b227999545dc88f5d96dd420d1c6c2128f3
    Gerrit-Change-Number: 7845117
    Gerrit-PatchSet: 3
    Gerrit-Owner: Clemens Backes <clem...@chromium.org>
    Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
    Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>
    Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
    Gerrit-Reviewer: Simon Zünd <szu...@chromium.org>
    Gerrit-Attention: Clemens Backes <clem...@chromium.org>
    Gerrit-Comment-Date: Tue, 19 May 2026 14:54:16 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages