[wasm][compiler] Avoid redundant instance data spills in wrappers [v8/v8 : main]
0 views
Skip to first unread message
Clemens Backes (Gerrit)
10:17 AM (11 hours ago) 10:17 AM
to Darius Mercadier, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Darius Mercadier
Clemens Backes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Clemens Backes . resolved
A mini optimization to avoid a spill here and there (only in wrappers).
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
10:50 AM (11 hours ago) 10:50 AM
to Clemens Backes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Clemens Backes
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
10:56 AM (10 hours ago) 10:56 AM
to Darius Mercadier, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Clemens Backes voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
10:58 AM (10 hours ago) 10:58 AM
to Clemens Backes, Darius Mercadier, dmercadi...@chromium.org, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasm][compiler] Avoid redundant instance data spills in wrappers
Wasm import wrappers and C-API functions push the instance data (or
import data) to a fixed stack slot in their prologue.
By identifying this dual-location in Linkage, the register allocator
can avoid emitting redundant spill moves when register pressure is
high.
R=dmerc...@chromium.org
Change-Id: Ibb7a9d981ba7f65967a3bd9cd42c50219ee28154
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108371}
Files:
- M src/compiler/linkage.cc
Change size: XS
Delta: 1 file changed, 4 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages