[api] Flatten v8::FunctionCallbackInfo<T> [v8/v8 : main]
0 views
Skip to first unread message
Igor Sheludko (Gerrit)
Dec 12, 2025, 6:12:54 AM (4 days ago) Dec 12
to Patrick Thier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Patrick Thier
Igor Sheludko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 12, 2025, 7:07:56 AM (4 days ago) Dec 12
to Igor Sheludko, Patrick Thier, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Igor Sheludko and Patrick Thier
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job linux-r350-perf/blink_perf.bindings complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1360585f310000
Related details
Attention is currently required from:
- Igor Sheludko
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 12, 2025, 7:15:35 AM (4 days ago) Dec 12
to Igor Sheludko, Patrick Thier, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Igor Sheludko and Patrick Thier
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job linux-r350-perf/speedometer3 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11846e8f310000
Related details
Attention is currently required from:
- Igor Sheludko
- Patrick Thier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Thier (Gerrit)
Dec 12, 2025, 7:17:31 AM (4 days ago) Dec 12
to Igor Sheludko, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Igor Sheludko
Patrick Thier voted and added 3 comments![]( "Open in Gerrit")
Votes added by Patrick Thier
| Code-Review | +1 |
3 comments
Patchset-level comments
File src/api/api-arguments-inl.h
Line 135, Patchset 11 (Latest):
// const base::Vector<const DirectHandle<Object>>Patrick Thier . unresolved
Leftover?
File src/builtins/builtins-api.cc
Line 63, Patchset 11 (Latest):
static_assert(std::is_same_v<ArgT, DirectHandle<Object>> ||Patrick Thier . unresolved
nit: You could use concepts instead.
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 12, 2025, 7:24:08 AM (4 days ago) Dec 12
to Igor Sheludko, Patrick Thier, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Igor Sheludko
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job linux-perf/speedometer3 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/123dbed7310000
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 12, 2025, 7:32:03 AM (4 days ago) Dec 12
to Igor Sheludko, Patrick Thier, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Igor Sheludko
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/blink_perf.bindings complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11f2d87f310000
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 12, 2025, 7:33:02 AM (4 days ago) Dec 12
to Igor Sheludko, Patrick Thier, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Igor Sheludko
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job win-11-perf/blink_perf.bindings complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12f39da3310000
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 12, 2025, 7:49:15 AM (4 days ago) Dec 12
to Igor Sheludko, Patrick Thier, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Igor Sheludko
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/blink_perf.bindings complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/11d8d533310000
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 12, 2025, 7:49:17 AM (4 days ago) Dec 12
to Igor Sheludko, Patrick Thier, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Igor Sheludko
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/speedometer3 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/1396a958b10000
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 12, 2025, 7:50:30 AM (4 days ago) Dec 12
to Igor Sheludko, Patrick Thier, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Igor Sheludko
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/speedometer3 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/124fece7310000
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Dec 12, 2025, 8:06:30 AM (4 days ago) Dec 12
to Igor Sheludko, Patrick Thier, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Igor Sheludko
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job win-11-perf/speedometer3 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/105886fb310000
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Dec 12, 2025, 8:13:40 AM (4 days ago) Dec 12
to Leszek Swirski, Patrick Thier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski
Igor Sheludko voted and added 3 comments![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Commit-Queue | +1 |
3 comments
Patchset-level comments
File-level comment, Patchset 12 (Latest):
Igor Sheludko . resolved
Thanks!
Leszek, PTAL @ include, debug and maglev
File src/api/api-arguments-inl.h
Line 135, Patchset 11:
// const base::Vector<const DirectHandle<Object>>Patrick Thier . resolved
Igor SheludkoLeftover?
Done
File src/builtins/builtins-api.cc
Line 63, Patchset 11:
static_assert(std::is_same_v<ArgT, DirectHandle<Object>> ||Patrick Thier . resolved
nit: You could use concepts instead.
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Dec 12, 2025, 8:32:56 AM (4 days ago) Dec 12
to Leszek Swirski, Patrick Thier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski
Igor Sheludko voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Dec 12, 2025, 8:39:56 AM (4 days ago) Dec 12
to Igor Sheludko, Patrick Thier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Igor Sheludko
Leszek Swirski added 2 comments![]( "Open in Gerrit")
File include/v8-function-callback.h
Line 216, Patchset 12 (Latest):
mutable internal::Address values_[1];Leszek Swirski . unresolved
is this mutable actually needed? Where does the GC mutate the values_ of a const reft to FunctionCallbackInfo?
Line 152, Patchset 12 (Latest):
enum {Leszek Swirski . unresolved
why have this enum at all, instead of defining the frame fields as members of the class? since you're already reinterpret casting, you could have
```
Address arg_c_;
Adresss frame_sp_;
...
Address args_[1]; // the receiver is the first arg
```
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Dec 12, 2025, 8:40:57 AM (4 days ago) Dec 12
to Igor Sheludko, Patrick Thier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Igor Sheludko
Leszek Swirski voted and added 1 comment![]( "Open in Gerrit")
Votes added by Leszek Swirski
| Code-Review | +1 |
1 comment
Patchset-level comments
Leszek Swirski . resolved
lgtm for the parts you asked me to look at, all comments are optional
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Dec 12, 2025, 9:38:58 AM (4 days ago) Dec 12
to Leszek Swirski, Patrick Thier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Igor Sheludko added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Igor Sheludko . resolved
Thanks! landing...
File include/v8-function-callback.h
Line 216, Patchset 12 (Latest):
mutable internal::Address values_[1];Leszek Swirski . resolved
is this mutable actually needed? Where does the GC mutate the values_ of a const reft to FunctionCallbackInfo?
Igor Sheludko
Without `mutable` we can't create handles in `const` methods - handle construction require non-const `Address*`. I thought it's better than using `const_cast`.
Leszek Swirski . resolved
why have this enum at all, instead of defining the frame fields as members of the class? since you're already reinterpret casting, you could have
```
Address arg_c_;
Adresss frame_sp_;
...
Address args_[1]; // the receiver is the first arg
```
Igor Sheludko
There are complications with optional constant pool field and new.target value. I was also thinking about making v8::FunctionCallbackInfo object just a wrapper around pointer and pass it to callbacks by value instead of by const reference as we do now.
Let's keep it like this for now and refactor later.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Dec 12, 2025, 9:40:05 AM (4 days ago) Dec 12
to Leszek Swirski, Patrick Thier, chrom...@appspot.gserviceaccount.com, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Igor Sheludko voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 12, 2025, 9:41:39 AM (4 days ago) Dec 12
to Igor Sheludko, Leszek Swirski, Patrick Thier, chrom...@appspot.gserviceaccount.com, cbruni...@chromium.org, devtools-...@chromium.org, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[api] Flatten v8::FunctionCallbackInfo<T>
... in order to simplify CallApiCallback builtin and avoid indirections
on access.
This CL
- makes v8::FunctionCallbackInfo<T> overlap with ApiCallbackExit
frame, so that address of the object points to the location on
stack where the arguments count is stored (then goes the ExitFrame
part including frame type, fp and pc, then goes Api callback
arguments, and finally receiver and JS arguments,
- adds new frame kind and frame type class for [[Construct]] calls to
Api functions (API_CONSTRUCT_EXIT and ApiConstructExitFrame), which
are not created by any builtins yet but such builtins will be added
in a follow-up CL,
- avoids the cost of passing new.target value for non-construct calls
(this is deduced from the frame type),
- drops kUnusedIndex argument,
- reorders StackFrame::Type enum values in order to make
API_CONSTRUCT_EXIT value build-mode independent (all Wasm-related
frame types are now moved to the end of list),
- removes copy/move constructors and assignment/move operators from
v8::FunctionCallbackInfo<T> as copying/moving the object is no
longer possible.
NO_IFTTT=Introducing IFTTT, no logical change.
Bug: 326505377
Change-Id: I84ddd3e5ed395164718547e6d05fb4dadc9fcb93
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Auto-Submit: Igor Sheludko <ish...@chromium.org>
Reviewed-by: Leszek Swirski <les...@chromium.org>
Reviewed-by: Patrick Thier <pth...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104295}
Files:
- M include/v8-function-callback.h
- M include/v8-internal.h
- M src/api/api-arguments-inl.h
- M src/api/api-arguments.h
- M src/builtins/arm/builtins-arm.cc
- M src/builtins/arm64/builtins-arm64.cc
- M src/builtins/builtins-api.cc
- M src/builtins/builtins-utils.h
- M src/builtins/ia32/builtins-ia32.cc
- M src/builtins/x64/builtins-x64.cc
- M src/codegen/x64/macro-assembler-x64.cc
- M src/codegen/x64/macro-assembler-x64.h
- M src/debug/debug-interface.cc
- M src/diagnostics/objects-printer.cc
- M src/execution/frame-constants.h
- M src/execution/frames-inl.h
- M src/execution/frames.cc
- M src/execution/frames.h
- M src/execution/isolate.cc
- M src/maglev/maglev-ir.cc
- M src/objects/objects.h
Change size: XL
Delta: 21 files changed, 693 insertions(+), 506 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Leszek Swirski, +1 by Patrick Thier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liu Yu (Gerrit)
Dec 15, 2025, 2:48:20 AM (yesterday) Dec 15
to Zhao Jiazhong, v8-mip...@googlegroups.com, v8-loongar...@chromium.org, v8-re...@googlegroups.com
Attention needed from Zhao Jiazhong
Liu Yu voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Zhao Jiazhong
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zhao Jiazhong (Gerrit)
Dec 15, 2025, 2:58:36 AM (yesterday) Dec 15
to Liu Yu, v8-mip...@googlegroups.com, v8-loongar...@chromium.org, v8-re...@googlegroups.com
Attention needed from Liu Yu
Zhao Jiazhong voted and added 1 comment![]( "Open in Gerrit")
Votes added by Zhao Jiazhong
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Liu Yu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 15, 2025, 3:33:17 AM (yesterday) Dec 15
to Liu Yu, Zhao Jiazhong, v8-mip...@googlegroups.com, v8-loongar...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[loong64][mips64][api] Flatten v8::FunctionCallbackInfo<T>
Port commit b9c4e374820a3bd42503aeae8917c7a8d4a79530
Bug: 326505377
Change-Id: Ib0fa1555a2c6f7ab5e988855bf9094bf827c297e
Auto-Submit: Liu Yu <li...@loongson.cn>
Reviewed-by: Zhao Jiazhong <zhaojia...@loongson.cn>
Commit-Queue: Zhao Jiazhong <zhaojia...@loongson.cn>
Cr-Commit-Position: refs/heads/main@{#104309}
Files:
- M src/builtins/loong64/builtins-loong64.cc
- M src/builtins/mips64/builtins-mips64.cc
Change size: M
Delta: 2 files changed, 47 insertions(+), 104 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Zhao Jiazhong
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ji Qiu (Gerrit)
Dec 15, 2025, 8:21:02 PM (10 hours ago) Dec 15
to Yahan Lu (LuYahan), V8 LUCI CQ, Kasper Lund, AyeAye, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Kasper Lund and Yahan Lu (LuYahan)
Ji Qiu voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Kasper Lund
- Yahan Lu (LuYahan)
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 15, 2025, 8:22:31 PM (10 hours ago) Dec 15
to Yahan Lu (LuYahan), Ji Qiu, Kasper Lund, AyeAye, v8-re...@googlegroups.com, v8-risc...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[riscv][api] Flatten v8::FunctionCallbackInfo<T>
Port commit b9c4e374820a3bd42503aeae8917c7a8d4a79530
Bug: 326505377
Change-Id: I7985cde80af48ee38f313d754776bd9a7368ff22
Reviewed-by: Ji Qiu <qi...@iscas.ac.cn>
Commit-Queue: Ji Qiu <qi...@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#104332}
Files:
- M src/builtins/riscv/builtins-riscv.cc
Change size: M
Delta: 1 file changed, 25 insertions(+), 57 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ji Qiu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages