[maglev] Slightly faster StringLengthStaticLowerBound [v8/v8 : main]

0 views
Skip to first unread message

Olivier Flückiger (Gerrit)

unread,
May 15, 2025, 8:13:23 AM5/15/25
to Victor Gomes, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes

Olivier Flückiger voted and added 1 comment

Votes added by Olivier Flückiger

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Olivier Flückiger . resolved

ptal.

This is the only conceivable reason for a potential Air regression if we enable cons strings -- with some local measurements suggesting that it could fix it...

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Gomes
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I684f8be1a223d1aa05cb2f75e45bc67c91ebb5ae
Gerrit-Change-Number: 6551779
Gerrit-PatchSet: 1
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Thu, 15 May 2025 12:13:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Olivier Flückiger (Gerrit)

unread,
May 15, 2025, 8:47:35 AM5/15/25
to V8 LUCI CQ, Victor Gomes, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes

Olivier Flückiger voted and added 1 comment

Votes added by Olivier Flückiger

Auto-Submit+0

1 comment

Patchset-level comments
Olivier Flückiger . resolved

ok, let's hold back on this. if https://chromium-review.googlesource.com/c/v8/v8/+/6549404 really does regress we can still investigate more

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Gomes
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I684f8be1a223d1aa05cb2f75e45bc67c91ebb5ae
Gerrit-Change-Number: 6551779
Gerrit-PatchSet: 1
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Thu, 15 May 2025 12:47:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Olivier Flückiger (Gerrit)

unread,
May 21, 2025, 2:57:54 AM5/21/25
to V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Olivier Flückiger abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I684f8be1a223d1aa05cb2f75e45bc67c91ebb5ae
Gerrit-Change-Number: 6551779
Gerrit-PatchSet: 1
Gerrit-Owner: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages