[Wasm interpreter] Fixes a few build breaks in Wasm interpreter [v8/v8 : main]
0 views
Skip to first unread message
Paolo Severini (Gerrit)
Sep 25, 2025, 12:30:22 PM (2 days ago) Sep 25
to Michael Lippautz, V8 LUCI CQ, Daniel Lehmann, v8-re...@googlegroups.com, was...@google.com
Attention needed from Daniel Lehmann and Michael Lippautz
Paolo Severini added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Paolo Severini . resolved
Adding @mlip...@chromium.org for the change to sandbox/js-dispatch-table-inl.h.
Related details
Attention is currently required from:
- Daniel Lehmann
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Sep 26, 2025, 3:22:05 AM (yesterday) Sep 26
to Paolo Severini, V8 LUCI CQ, Daniel Lehmann, v8-re...@googlegroups.com, was...@google.com
Attention needed from Daniel Lehmann and Paolo Severini
Michael Lippautz added 1 comment![]( "Open in Gerrit")
File src/sandbox/js-dispatch-table-inl.h
Line 338, Patchset 1 (Latest):
#ifdef V8_ENABLE_DRUMBRAKEMichael Lippautz . unresolved
This is already part of the switch below on L373. What makes this necessary here?
Related details
Attention is currently required from:
- Daniel Lehmann
- Paolo Severini
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paolo Severini (Gerrit)
Sep 26, 2025, 7:22:25 AM (yesterday) Sep 26
to Michael Lippautz, V8 LUCI CQ, Daniel Lehmann, v8-re...@googlegroups.com, was...@google.com
Attention needed from Daniel Lehmann and Michael Lippautz
Paolo Severini added 1 comment![]( "Open in Gerrit")
File src/sandbox/js-dispatch-table-inl.h
This is already part of the switch below on L373. What makes this necessary here?
Paolo Severini
You are right, this change does not seem necessary anymore. There have been several changes to this file recently and at some point we saw a number of tests failing in jitless mode with this call stack:
```
#
# Fatal error in , line 0
# Check failed: IsCompatibleCode(new_code, parameter_count).
#
#
#
#FailureMessage Object: 0000009669BFD530
==== C stack trace ===============================
v8::base::debug::StackTrace::StackTrace [0x0x7ff6abf9971b+27] (D:\a\_work\e\v8\src\base\debug\stack_trace_win.cc:173)
v8::platform::`anonymous namespace'::PrintStackTrace [0x0x7ff6abf093a7+39] (D:\a\_work\e\v8\src\libplatform\default-platform.cc:28)
V8_Fatal [0x0x7ff6abefe9a7+295] (D:\a\_work\e\v8\src\base\logging.cc:214)
v8::internal::JSDispatchTable::TryAllocateAndInitializeEntry [0x0x7ff6aac07313+499] (D:\a\_work\e\v8\src\sandbox\js-dispatch-table-inl.h:171)
v8::internal::FactoryBase<v8::internal::Factory>::NewJSDispatchHandle [0x0x7ff6aabffe09+137] (D:\a\_work\e\v8\src\heap\factory-base.cc:1496)
v8::internal::Factory::JSFunctionBuilder::BuildRaw [0x0x7ff6aac1efbc+1148] (D:\a\_work\e\v8\src\heap\factory.cc:4970)
v8::internal::Factory::JSFunctionBuilder::Build [0x0x7ff6aac1196a+138] (D:\a\_work\e\v8\src\heap\factory.cc:4832)
v8::internal::WasmExportedFunction::New [0x0x7ff6ab51b419+1177] (D:\a\_work\e\v8\src\wasm\wasm-objects.cc:3037)
v8::internal::WasmTrustedInstanceData::GetOrCreateFuncRef [0x0x7ff6ab5147bb+843] (D:\a\_work\e\v8\src\wasm\wasm-objects.cc:2055)
v8::internal::wasm::InstanceBuilder::ProcessExports [0x0x7ff6ab49bffd+1181] (D:\a\_work\e\v8\src\wasm\module-instantiate.cc:2531)
v8::internal::wasm::InstanceBuilder::Build_Phase1 [0x0x7ff6ab49a2d9+3961] (D:\a\_work\e\v8\src\wasm\module-instantiate.cc:1413)
v8::internal::wasm::InstanceBuilder::Build [0x0x7ff6ab498856+470] (D:\a\_work\e\v8\src\wasm\module-instantiate.cc:1077)
v8::internal::wasm::InstantiateToInstanceObject [0x0x7ff6ab4981e3+195] (D:\a\_work\e\v8\src\wasm\module-instantiate.cc:1019)
v8::internal::wasm::WasmEngine::SyncInstantiate [0x0x7ff6ab4ddbc9+409] (D:\a\_work\e\v8\src\wasm\wasm-engine.cc:756)
v8::internal::wasm::WebAssemblyInstance [0x0x7ff6ab4f5e06+582] (D:\a\_work\e\v8\src\wasm\wasm-js.cc:3196)
v8::internal::FunctionCallbackArguments::CallOrConstruct [0x0x7ff6aaa2b321+305] (D:\a\_work\e\v8\src\api\api-arguments-inl.h:94)
v8::internal::`anonymous namespace'::HandleApiCallHelper<1> [0x0x7ff6aaa2a77b+379] (D:\a\_work\e\v8\src\builtins\builtins-api.cc:106)
v8::internal::Builtin_Impl_HandleApiConstruct [0x0x7ff6aaa29e79+201] (D:\a\_work\e\v8\src\builtins\builtins-api.cc:135)
v8::internal::Builtin_HandleApiConstruct [0x0x7ff6aaa29ad0+48] (D:\a\_work\e\v8\src\builtins\builtins-api.cc:126)
Builtins_CEntry_Return1_ArgvOnStack_BuiltinExit [0x0x7ff6ac2c8b7a+58]
Builtins_InterpreterPushArgsThenFastConstructFunction [0x0x7ff6ac2be973+691]
Builtins_ConstructHandler [0x0x7ff6ac27a500+192]
[...]
Command: out\Debug_x64\d8.exe --test test\mjsunit\mjsunit.js test\mjsunit\wasm\futex.js --random-seed=-46250982 --nohard-abort --testing-d8-test-runner --jitless --wasm-jitless-if-available-for-testing --allow-natives-syntax
--- FAILED ---
```
But I see that the tests are not failing anymore.
Related details
Attention is currently required from:
- Daniel Lehmann
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Sep 26, 2025, 7:32:27 AM (yesterday) Sep 26
to Paolo Severini, V8 LUCI CQ, Daniel Lehmann, v8-re...@googlegroups.com, was...@google.com
Attention needed from Daniel Lehmann and Paolo Severini
Michael Lippautz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Lippautz
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Daniel Lehmann
- Paolo Severini
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paolo Severini (Gerrit)
Sep 26, 2025, 8:32:02 AM (yesterday) Sep 26
to Michael Lippautz, V8 LUCI CQ, Daniel Lehmann, v8-re...@googlegroups.com, was...@google.com
Attention needed from Daniel Lehmann
Paolo Severini voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Daniel Lehmann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Sep 26, 2025, 8:37:05 AM (yesterday) Sep 26
to Paolo Severini, Michael Lippautz, Daniel Lehmann, v8-re...@googlegroups.com, was...@google.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[Wasm interpreter] Fixes a few build breaks in Wasm interpreter
Fix a couple of build breaks in the Wasm interpreter after the refactoring of Simd128.
Bug: 338326645
Change-Id: Idf04177ab54d94575ab113245eac9f26ecbe958a
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Paolo Severini <paol...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#102793}
Files:
- M src/wasm/interpreter/wasm-interpreter.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages