Handle empty blocks in --trace-turbo printing [v8/v8 : main]
0 views
Skip to first unread message
Nico Hartmann (Gerrit)
Feb 3, 2026, 4:42:55 AM (24 hours ago) Feb 3
to Matthias Liedtke, V8 LUCI CQ, AyeAye, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke
Nico Hartmann voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Hartmann
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Matthias Liedtke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthias Liedtke (Gerrit)
Feb 3, 2026, 10:56:28 AM (17 hours ago) Feb 3
to Nico Hartmann, V8 LUCI CQ, AyeAye, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Nico Hartmann
Matthias Liedtke voted and added 2 comments![]( "Open in Gerrit")
Votes added by Matthias Liedtke
| Code-Review | +1 |
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File test/mjsunit/regress/regress-479872236.js
Line 5, Patchset 4 (Latest):
// Flags: --allow-natives-syntaxMatthias Liedtke . resolved
Wouldn't this test need some printing flag to reproduce the issue? (I guess, we don't want to write files and we don't have a stdout flag for that?
Related details
Attention is currently required from:
- Nico Hartmann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Feb 3, 2026, 11:44:33 AM (17 hours ago) Feb 3
to Nico Hartmann, Matthias Liedtke, AyeAye, dmercadi...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[turboshaft] Handle empty blocks in --trace-turbo printing
Bug: 479872236
Change-Id: Iefca6ae5d06755d961f8372c888ae2d8317fc3d6
Auto-Submit: Nico Hartmann <nicoha...@chromium.org>
Reviewed-by: Matthias Liedtke <mlie...@chromium.org>
Commit-Queue: Matthias Liedtke <mlie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105066}
Files:
- M src/compiler/turboshaft/graph-visualizer.cc
- A test/mjsunit/regress/regress-479872236.js
Change size: S
Delta: 2 files changed, 23 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Matthias Liedtke
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages