[tools] add `v8 isolate` to debug helper plugins [v8/v8 : main]

0 views
Skip to first unread message

Joyee Cheung (Gerrit)

unread,
Jul 24, 2026, 8:35:19 AM (20 hours ago) Jul 24
to Paolo Severini, v8-re...@googlegroups.com
Attention needed from Paolo Severini

Joyee Cheung voted and added 1 comment

Votes added by Joyee Cheung

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Joyee Cheung . resolved

PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Paolo Severini
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I2986986bf3a3760fbb86cda78ffc9a779152337f
Gerrit-Change-Number: 8117610
Gerrit-PatchSet: 7
Gerrit-Owner: Joyee Cheung <jo...@igalia.com>
Gerrit-Reviewer: Joyee Cheung <jo...@igalia.com>
Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
Gerrit-Attention: Paolo Severini <paol...@microsoft.com>
Gerrit-Comment-Date: Fri, 24 Jul 2026 12:35:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Paolo Severini (Gerrit)

unread,
Jul 24, 2026, 8:53:42 AM (20 hours ago) Jul 24
to Joyee Cheung, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Joyee Cheung

Paolo Severini voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joyee Cheung
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I2986986bf3a3760fbb86cda78ffc9a779152337f
Gerrit-Change-Number: 8117610
Gerrit-PatchSet: 7
Gerrit-Owner: Joyee Cheung <jo...@igalia.com>
Gerrit-Reviewer: Joyee Cheung <jo...@igalia.com>
Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
Gerrit-Attention: Joyee Cheung <jo...@igalia.com>
Gerrit-Comment-Date: Fri, 24 Jul 2026 12:53:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Joyee Cheung (Gerrit)

unread,
Jul 24, 2026, 9:28:21 AM (20 hours ago) Jul 24
to Paolo Severini, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com

Joyee Cheung voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I2986986bf3a3760fbb86cda78ffc9a779152337f
Gerrit-Change-Number: 8117610
Gerrit-PatchSet: 7
Gerrit-Owner: Joyee Cheung <jo...@igalia.com>
Gerrit-Reviewer: Joyee Cheung <jo...@igalia.com>
Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
Gerrit-Comment-Date: Fri, 24 Jul 2026 13:28:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Jul 24, 2026, 9:30:32 AM (19 hours ago) Jul 24
to Joyee Cheung, Paolo Severini, v8-re...@googlegroups.com

v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[tools] add `v8 isolate` to debug helper plugins

Similar to the `@$curisolate()` command in the windbg plugin,
this prints the address of the Isolate for the current thread.

To make up for the lack of TLS variable resolution support in
lldb especially for core dumps, this includes a hand-rolled
implementation of TLS variable resolution for both ELF and
Mach-O.
Change-Id: I2986986bf3a3760fbb86cda78ffc9a779152337f
Commit-Queue: Joyee Cheung <jo...@igalia.com>
Reviewed-by: Paolo Severini <paol...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#108866}
Files:
  • M tools/debug_helper/plugins/README.md
  • M tools/debug_helper/plugins/gdb_plugin.py
  • M tools/debug_helper/plugins/lldb_plugin.py
  • A tools/debug_helper/plugins/test/helpers/isolate.py
  • M tools/debug_helper/plugins/test/helpers/session.py
  • M tools/debug_helper/plugins/test/test_gdb_core.py
  • M tools/debug_helper/plugins/test/test_gdb_live.py
  • M tools/debug_helper/plugins/test/test_lldb_core.py
  • M tools/debug_helper/plugins/test/test_lldb_live.py
  • M tools/debug_helper/plugins/v8dbg/commands.py
  • A tools/debug_helper/plugins/v8dbg/hints.py
Change size: L
Delta: 11 files changed, 722 insertions(+), 89 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Paolo Severini
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I2986986bf3a3760fbb86cda78ffc9a779152337f
Gerrit-Change-Number: 8117610
Gerrit-PatchSet: 8
Gerrit-Owner: Joyee Cheung <jo...@igalia.com>
Gerrit-Reviewer: Joyee Cheung <jo...@igalia.com>
Gerrit-Reviewer: Paolo Severini <paol...@microsoft.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages