[tools] Include version in title for roll cherry-picks [v8/v8 : main]

0 views
Skip to first unread message

Clemens Backes (Gerrit)

unread,
Jan 8, 2026, 9:15:25 AM (21 hours ago) Jan 8
to Matthias Liedtke, Leszek Swirski, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke

Clemens Backes added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Clemens Backes . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Matthias Liedtke
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Icb410b9663b404d97b05c06a0d2ef77d0b1c7788
Gerrit-Change-Number: 7414702
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-CC: Leszek Swirski <les...@chromium.org>
Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 14:15:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Leszek Swirski (Gerrit)

unread,
Jan 8, 2026, 9:16:05 AM (21 hours ago) Jan 8
to Clemens Backes, Matthias Liedtke, v8-re...@googlegroups.com
Attention needed from Clemens Backes and Matthias Liedtke

Leszek Swirski voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
  • Matthias Liedtke
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Icb410b9663b404d97b05c06a0d2ef77d0b1c7788
Gerrit-Change-Number: 7414702
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 14:16:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Matthias Liedtke (Gerrit)

unread,
Jan 8, 2026, 9:16:50 AM (21 hours ago) Jan 8
to Clemens Backes, V8 LUCI CQ, Leszek Swirski, v8-re...@googlegroups.com
Attention needed from Clemens Backes

Matthias Liedtke voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Icb410b9663b404d97b05c06a0d2ef77d0b1c7788
Gerrit-Change-Number: 7414702
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 14:16:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Clemens Backes (Gerrit)

unread,
Jan 8, 2026, 9:33:13 AM (21 hours ago) Jan 8
to Matthias Liedtke, V8 LUCI CQ, Leszek Swirski, v8-re...@googlegroups.com

Clemens Backes voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Icb410b9663b404d97b05c06a0d2ef77d0b1c7788
Gerrit-Change-Number: 7414702
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 14:33:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Jan 8, 2026, 9:49:54 AM (20 hours ago) Jan 8
to Clemens Backes, Matthias Liedtke, Leszek Swirski, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[tools] Include version in title for roll cherry-picks

This fixes a problem introduced by https://crrev.com/c/7177561:
The chat bot does not find a new version number on the merge and uses
the version number it finds on the older (non-merge) CL instead.

R=mlie...@chromium.org
CC=les...@chromium.org
Change-Id: Icb410b9663b404d97b05c06a0d2ef77d0b1c7788
Reviewed-by: Matthias Liedtke <mlie...@chromium.org>
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Leszek Swirski <les...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104561}
Files:
  • M tools/release/roll_merge_gerrit.py
Change size: XS
Delta: 1 file changed, 1 insertion(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Leszek Swirski, +1 by Matthias Liedtke
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Icb410b9663b404d97b05c06a0d2ef77d0b1c7788
Gerrit-Change-Number: 7414702
Gerrit-PatchSet: 2
Gerrit-Owner: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages