Fix declaration of CppGCManaged in GCC [v8/v8 : main]

[Joyee Cheung (Gerrit)]

Attention needed from Andreas Haas

Joyee Cheung added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Joyee Cheung . resolved

PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Andreas Haas

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Iaf28bb84bcf886c9295563df9218777ea190aed4

Gerrit-Change-Number: 8250422

Gerrit-PatchSet: 1

Gerrit-Owner: Joyee Cheung <jo...@igalia.com>

Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>

Gerrit-Attention: Andreas Haas <ah...@chromium.org>

Gerrit-Comment-Date: Fri, 14 Aug 2026 11:14:06 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Andreas Haas (Gerrit)]

Attention needed from Joyee Cheung

Andreas Haas voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Joyee Cheung

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Iaf28bb84bcf886c9295563df9218777ea190aed4

Gerrit-Change-Number: 8250422

Gerrit-PatchSet: 1

Gerrit-Owner: Joyee Cheung <jo...@igalia.com>

Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>

Gerrit-Attention: Joyee Cheung <jo...@igalia.com>

Gerrit-Comment-Date: Fri, 14 Aug 2026 12:08:16 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Joyee Cheung (Gerrit)]

Joyee Cheung voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Iaf28bb84bcf886c9295563df9218777ea190aed4

Gerrit-Change-Number: 8250422

Gerrit-PatchSet: 1

Gerrit-Owner: Joyee Cheung <jo...@igalia.com>

Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>

Gerrit-Reviewer: Joyee Cheung <jo...@igalia.com>

Gerrit-CC: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Comment-Date: Fri, 14 Aug 2026 15:56:07 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)]

v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:

Fix declaration of CppGCManaged in GCC

GCC does not allow pragmas in the middle of the template declaration.
Put the V8_OBJECT macro in front of the template declaration,
which is supported by both GCC and Clang.

Change-Id: Iaf28bb84bcf886c9295563df9218777ea190aed4

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8250422

Commit-Queue: Joyee Cheung <jo...@igalia.com>

Reviewed-by: Andreas Haas <ah...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#109262}

Files:

• M src/objects/managed.h

Change size: XS

Delta: 1 file changed, 2 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Andreas Haas

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: Iaf28bb84bcf886c9295563df9218777ea190aed4

Gerrit-Change-Number: 8250422

Gerrit-PatchSet: 2

Gerrit-Owner: Joyee Cheung <jo...@igalia.com>

Gerrit-Reviewer: Andreas Haas <ah...@chromium.org>

Gerrit-Reviewer: Joyee Cheung <jo...@igalia.com>

Gerrit-Reviewer: v8-s...@luci-project-accounts.iam.gserviceaccount.com <v8-s...@luci-project-accounts.iam.gserviceaccount.com>