[cleanup] Typo fix on GetLoadFieldByIndex's comment [v8/v8 : master]

1 view
Skip to first unread message

Santiago Aboy Solanes (Gerrit)

unread,
Feb 8, 2021, 3:54:32 PM2/8/21
to Nico Hartmann, v8-re...@googlegroups.com

Attention is currently required from: Nico Hartmann.

Patch set 1:Auto-Submit +1

View Change

1 comment:

To view, visit change 2682643. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: v8/v8
Gerrit-Branch: master
Gerrit-Change-Id: I00754c295cd7b0de11f7ae039b423abfb9db5716
Gerrit-Change-Number: 2682643
Gerrit-PatchSet: 1
Gerrit-Owner: Santiago Aboy Solanes <sol...@chromium.org>
Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Reviewer: Santiago Aboy Solanes <sol...@chromium.org>
Gerrit-CC: Commit Bot <commi...@chromium.org>
Gerrit-Attention: Nico Hartmann <nicoha...@chromium.org>
Gerrit-Comment-Date: Mon, 08 Feb 2021 20:54:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Nico Hartmann (Gerrit)

unread,
Feb 9, 2021, 3:34:23 AM2/9/21
to Santiago Aboy Solanes, v8-re...@googlegroups.com

Attention is currently required from: Santiago Aboy Solanes.

Patch set 1:Code-Review +1Commit-Queue +2

View Change

    To view, visit change 2682643. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: v8/v8
    Gerrit-Branch: master
    Gerrit-Change-Id: I00754c295cd7b0de11f7ae039b423abfb9db5716
    Gerrit-Change-Number: 2682643
    Gerrit-PatchSet: 1
    Gerrit-Owner: Santiago Aboy Solanes <sol...@chromium.org>
    Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
    Gerrit-Reviewer: Santiago Aboy Solanes <sol...@chromium.org>
    Gerrit-CC: Commit Bot <commi...@chromium.org>
    Gerrit-Attention: Santiago Aboy Solanes <sol...@chromium.org>
    Gerrit-Comment-Date: Tue, 09 Feb 2021 08:34:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Commit Bot (Gerrit)

    unread,
    Feb 9, 2021, 3:35:39 AM2/9/21
    to Santiago Aboy Solanes, Nico Hartmann, v8-re...@googlegroups.com

    Commit Bot submitted this change.

    View Change

    Approvals: Nico Hartmann: Looks good to me; Commit Santiago Aboy Solanes: Send CL to CQ automatically after approval
    [cleanup] Typo fix on GetLoadFieldByIndex's comment

    Bug: v8:11384
    Change-Id: I00754c295cd7b0de11f7ae039b423abfb9db5716
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2682643
    Commit-Queue: Nico Hartmann <nicoha...@chromium.org>
    Auto-Submit: Santiago Aboy Solanes <sol...@chromium.org>
    Reviewed-by: Nico Hartmann <nicoha...@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72575}
    ---
    M src/objects/field-index-inl.h
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/src/objects/field-index-inl.h b/src/objects/field-index-inl.h
    index a3b4c23..09056cf 100644
    --- a/src/objects/field-index-inl.h
    +++ b/src/objects/field-index-inl.h
    @@ -39,7 +39,7 @@
    first_inobject_offset);
    }

    -// Returns the index format accepted by the HLoadFieldByIndex instruction.
    +// Returns the index format accepted by the LoadFieldByIndex instruction.
    // (In-object: zero-based from (object start + JSObject::kHeaderSize),
    // out-of-object: zero-based from FixedArray::kHeaderSize.)
    int FieldIndex::GetLoadByFieldIndex() const {

    To view, visit change 2682643. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: v8/v8
    Gerrit-Branch: master
    Gerrit-Change-Id: I00754c295cd7b0de11f7ae039b423abfb9db5716
    Gerrit-Change-Number: 2682643
    Gerrit-PatchSet: 2
    Gerrit-Owner: Santiago Aboy Solanes <sol...@chromium.org>
    Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
    Gerrit-Reviewer: Nico Hartmann <nicoha...@chromium.org>
    Gerrit-Reviewer: Santiago Aboy Solanes <sol...@chromium.org>
    Gerrit-MessageType: merged
    Reply all
    Reply to author
    Forward
    0 new messages