v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/9079aeef..6f55d0c2
Roll created at https://cr-buildbucket.appspot.com/build/8693009842198408849
no-export: true
R=ol...@chromium.org,rez...@chromium.org
diff --git a/DEPS b/DEPS
index c4f7871..1a09195 100644
--- a/DEPS
+++ b/DEPS
@@ -182,7 +182,7 @@
'test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'test/test262/data':
- Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '9079aeefcefcd55b0e994fb8bda51e06827337bd',
+ Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '6f55d0c2f5f266873883be020cf42c29c450e5c9',
'third_party/android_platform': {
'url': Var('chromium_url') + '/chromium/src/third_party/android_platform.git' + '@' + 'e3919359f2387399042d31401817db4a02d756ec',
'condition': 'checkout_android',
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/9079aeef..6f55d0c2
Roll created at https://cr-buildbucket.appspot.com/build/8693009842198408849
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
'intl402/Temporal/PlainDate/canonicalize-calendar': [SKIP],| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/6f55d0c2..fff41f05
Roll created at https://cr-buildbucket.appspot.com/build/8692375663615854481
no-export: true
R=ol...@chromium.org,rez...@chromium.org
diff --git a/DEPS b/DEPS
index 6d3f548..e8b973c 100644
--- a/DEPS
+++ b/DEPS
@@ -170,7 +170,7 @@
'test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'test/test262/data':
- Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '6f55d0c2f5f266873883be020cf42c29c450e5c9',
+ Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + 'fff41f0522ede859d0880acbff066b09fc9c22a5',
'third_party/android_platform': {
'url': Var('chromium_url') + '/chromium/src/third_party/android_platform.git' + '@' + 'e3919359f2387399042d31401817db4a02d756ec',
'condition': 'checkout_android',
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Commit-Queue | +2 |
LGTM
'built-ins/Temporal/PlainDate/from/month-code-wrong-type': [SKIP], 'intl402/Temporal/PlainYearMonth/from/extreme-dates': [SKIP],| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/6f55d0c2..fff41f05
Roll created at https://cr-buildbucket.appspot.com/build/8692375663615854481
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
'built-ins/Temporal/PlainDate/from/month-code-wrong-type': [SKIP],Olivier Flückigerfix: https://chromium-review.googlesource.com/c/v8/v8/+/7493793
If it's already fixed we should remove the SKIPing again.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
'built-ins/Temporal/PlainDate/from/month-code-wrong-type': [SKIP],Olivier Flückigerfix: https://chromium-review.googlesource.com/c/v8/v8/+/7493793
If it's already fixed we should remove the SKIPing again.
Yeah, I plan to once the upstream fix lands.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/e85173bc..3c6180f5
Roll created at https://cr-buildbucket.appspot.com/build/8691741482899630353
no-export: true
R=ol...@chromium.org,rez...@chromium.org
diff --git a/DEPS b/DEPS
index f73e9bd..56f15e1 100644
--- a/DEPS
+++ b/DEPS
@@ -170,7 +170,7 @@
'test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'test/test262/data':
- Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + 'e85173bc211eb110477de3279ec1dcd36d9a8a58',
+ Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '3c6180f581e5f468d6767af2f9b1f9c3ca444e77',
'third_party/android_platform': {
'url': Var('chromium_url') + '/chromium/src/third_party/android_platform.git' + '@' + 'e3919359f2387399042d31401817db4a02d756ec',
'condition': 'checkout_android',
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Commit-Queue | +1 |
Probably the new Meiji start date spec/test change
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Probably the new Meiji start date spec/test change
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +1 |
Manish GoregaokarProbably the new Meiji start date spec/test change
Here's your fix: https://chromium-review.googlesource.com/c/chromium/src/+/7516950
If you'd like you can wait for that to land and update third_party/rust in DEPS here so that we don't need to do another "remove SKIPs" CL later.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +0 |
Probably can be superseded by https://chromium-review.googlesource.com/c/v8/v8/+/7518037
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Probably the new Meiji start date spec/test change
Here's your fix: https://chromium-review.googlesource.com/c/chromium/src/+/7516950
If you'd like you can wait for that to land and update third_party/rust in DEPS here so that we don't need to do another "remove SKIPs" CL later.
Thanks a lot.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/3c6180f5..dd6138f9
Roll created at https://cr-buildbucket.appspot.com/build/8691107305230788801
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/3c6180f5..dd6138f9
Roll created at https://cr-buildbucket.appspot.com/build/8691107305230788801
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/dd6138f9..f2d59ea6
Roll created at https://cr-buildbucket.appspot.com/build/8690473126429302049
no-export: true
R=ol...@chromium.org,rez...@chromium.org
diff --git a/DEPS b/DEPS
index 170b52a..d3d6d68 100644
--- a/DEPS
+++ b/DEPS
@@ -170,7 +170,7 @@
'test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'test/test262/data':
- Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + 'dd6138f9bc1aa2c3ba9cbf54452049b9a92c4e13',
+ Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + 'f2d59ea6e4b2f6f87de9f0d18a41d73782b6a9bc',
'third_party/android_platform': {
'url': Var('chromium_url') + '/chromium/src/third_party/android_platform.git' + '@' + 'e3919359f2387399042d31401817db4a02d756ec',
'condition': 'checkout_android',
diff --git a/test/test262/local-tests/test/staging/built-ins/RegExp/escape/surrogate-pair.js b/test/test262/local-tests/test/staging/built-ins/RegExp/escape/surrogate-pair.js
deleted file mode 100644
index af35e3a..0000000
--- a/test/test262/local-tests/test/staging/built-ins/RegExp/escape/surrogate-pair.js
+++ /dev/null
@@ -1,9 +0,0 @@
-// Copyright (C) 2025 the V8 project authors. All rights reserved.
-// This code is governed by the BSD license found in the LICENSE file.
-
-/*---
-description: Unescaped surrogate pairs
-features: [RegExp.escape]
----*/
-
-assert.sameValue(RegExp.escape("\ud800\udc00"), "\ud800\udc00", 'Unescaped surrogate pair');
diff --git a/test/test262/test262.status b/test/test262/test262.status
index b1c1b62..7da750d 100644
--- a/test/test262/test262.status
+++ b/test/test262/test262.status
@@ -386,7 +386,6 @@
'staging/sm/regress/regress-610026': [SKIP],
# https://github.com/rbuckton/ecma262/pull/14
- 'staging/explicit-resource-management/await-using-in-switch-case-block': [SKIP],
'staging/explicit-resource-management/call-dispose-methods': [SKIP],
############################ SLOW TESTS #############################
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
FYI Manish. Please do not +1 this CL, I want to make sure Oli sees my comments. Thank you!
// Copyright (C) 2025 the V8 project authors. All rights reserved.No idea why this is merged so late:
https://github.com/tc39/test262/commit/2f5001b0c68b311f8a0ecc7dd1604c33a7b56368
'staging/explicit-resource-management/await-using-in-switch-case-block': [SKIP],
'staging/explicit-resource-management/call-dispose-methods': [SKIP],| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +2 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
I still need another +1 on this. Oli or Manish, can someone +1 this?
// Copyright (C) 2025 the V8 project authors. All rights reserved.No idea why this is merged so late:
https://github.com/tc39/test262/commit/2f5001b0c68b311f8a0ecc7dd1604c33a7b56368
Acknowledged
# https://github.com/rbuckton/ecma262/pull/14
'staging/explicit-resource-management/await-using-in-switch-case-block': [SKIP],
'staging/explicit-resource-management/call-dispose-methods': [SKIP],My PR merged recently:
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
lgtm. Ihaven't had time to investigate the failures but I'll just wait for this to land first
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Owners-Override | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/dd6138f9..f2d59ea6
Roll created at https://cr-buildbucket.appspot.com/build/8690473126429302049
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/f2d59ea6..96639c7d
Roll created at https://cr-buildbucket.appspot.com/build/8689838946747952145
no-export: true
R=ol...@chromium.org,rez...@chromium.org
diff --git a/DEPS b/DEPS
index b0cc5c5..52b1705 100644
--- a/DEPS
+++ b/DEPS
@@ -170,7 +170,7 @@
'test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'test/test262/data':
- Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + 'f2d59ea6e4b2f6f87de9f0d18a41d73782b6a9bc',
+ Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '96639c7dfeb9b070978ab8b37ed695742cbc56d3',
'third_party/android_platform': {
'url': Var('chromium_url') + '/chromium/src/third_party/android_platform.git' + '@' + 'e3919359f2387399042d31401817db4a02d756ec',
'condition': 'checkout_android',
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +2 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/f2d59ea6..96639c7d
Roll created at https://cr-buildbucket.appspot.com/build/8689838946747952145
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/96639c7d..3aa9cb2c
Roll created at https://cr-buildbucket.appspot.com/build/8689204767868991857
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
+manish fyi, this seems to be a new split off test, which is still red for us.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
+manish fyi, this seems to be a new split off test, which is still red for us.
Yeah makes sense. Frank may or may not have time to look at all of the formatting related failures.
I might start having a look soon.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/96639c7d..3aa9cb2c
Roll created at https://cr-buildbucket.appspot.com/build/8689204767868991857
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/3aa9cb2c..dc0a3516
Roll created at https://cr-buildbucket.appspot.com/build/8688570589699840209
no-export: true
R=ol...@chromium.org,rez...@chromium.org
diff --git a/DEPS b/DEPS
index 8a42529..4edc166 100644
--- a/DEPS
+++ b/DEPS
@@ -170,7 +170,7 @@
'test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'test/test262/data':
- Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '3aa9cb2c71afc21aefc1f82e899af1d0403351ba',
+ Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + 'dc0a3516b0192a05861a08909ed7cff4fe615843',
'third_party/android_platform': {
'url': Var('chromium_url') + '/chromium/src/third_party/android_platform.git' + '@' + 'e3919359f2387399042d31401817db4a02d756ec',
'condition': 'checkout_android',
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
Manish, can you please +1 this! The failures are also related to temporal.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
Yeah, by and large there are many bugs in the Intl-Temporal integration that Frank has to look at at some point. I could start looking at them but I don't have tons of time for that right now.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yeah, by and large there are many bugs in the Intl-Temporal integration that Frank has to look at at some point. I could start looking at them but I don't have tons of time for that right now.
Got it. So I'll file an issue and assign it to Frank. Thanks for the info!
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +2 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/3aa9cb2c..dc0a3516
Roll created at https://cr-buildbucket.appspot.com/build/8688570589699840209
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/dc0a3516..63829c6d
Roll created at https://cr-buildbucket.appspot.com/build/8687936411654075761
no-export: true
R=ol...@chromium.org,rez...@chromium.org
diff --git a/DEPS b/DEPS
index e577393..87282a4 100644
--- a/DEPS
+++ b/DEPS
@@ -170,7 +170,7 @@
'test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'test/test262/data':
- Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + 'dc0a3516b0192a05861a08909ed7cff4fe615843',
+ Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '63829c6d925e24a3f5f307b08754aaa1c412c6a6',
'third_party/android_platform': {
'url': Var('chromium_url') + '/chromium/src/third_party/android_platform.git' + '@' + 'e3919359f2387399042d31401817db4a02d756ec',
'condition': 'checkout_android',
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Friendly ping :)
| Code-Review | +1 |
Seems fine, I don't have time to investigate these now but I probably will in a few weeks
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
(sorry, I saw this go by, did not know you wanted r+)
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/dc0a3516..63829c6d
Roll created at https://cr-buildbucket.appspot.com/build/8687936411654075761
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-ci-autoroll-builder would like Olivier Flückiger and Rezvan Mahdavi Hezaveh to review this change.
[test262] Roll test262
This roll requires a manual review. See http://go/reviewed-rolls for guidance.
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/63829c6d..3a9ecbea
Roll created at https://cr-buildbucket.appspot.com/build/8687302232344824865
no-export: true
R=ol...@chromium.org,rez...@chromium.org
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |