[riscv][maglev] Zero-extend Int32 index in element address [v8/v8 : main]

0 views
Skip to first unread message

Yahan Lu (LuYahan) (Gerrit)

unread,
Aug 9, 2026, 10:41:26 PM (6 days ago) Aug 9
to dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, victorgo...@chromium.org, verwaes...@chromium.org, v8-risc...@chromium.org

Yahan Lu (LuYahan) has uploaded the change for review

Commit message

[riscv][maglev] Zero-extend Int32 index in element address

Port commit 577d0cda2bb1d47a5132bef327371404e6fcde80
Bug: 513340698
Change-Id: Id08ab7c5944135af741edf646b7632c5c235880a

Change diff


Change information

Files:
  • M src/maglev/riscv/maglev-assembler-riscv-inl.h
  • M test/unittests/maglev/maglev-assembler-unittest.cc
Change size: S
Delta: 2 files changed, 26 insertions(+), 11 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id08ab7c5944135af741edf646b7632c5c235880a
Gerrit-Change-Number: 8221145
Gerrit-PatchSet: 1
Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
unsatisfied_requirement
open
diffy

Ji Qiu (Gerrit)

unread,
Aug 10, 2026, 3:38:17 AM (5 days ago) Aug 10
to Yahan Lu (LuYahan), Darius Mercadier, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier and Yahan Lu (LuYahan)

Ji Qiu voted and added 1 comment

Votes added by Ji Qiu

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Darius Mercadier
  • Yahan Lu (LuYahan)
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Id08ab7c5944135af741edf646b7632c5c235880a
    Gerrit-Change-Number: 8221145
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
    Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
    Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
    Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>
    Gerrit-Attention: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
    Gerrit-Comment-Date: Mon, 10 Aug 2026 07:38:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Darius Mercadier (Gerrit)

    unread,
    Aug 14, 2026, 11:03:45 AM (yesterday) Aug 14
    to Yahan Lu (LuYahan), v8-s...@luci-project-accounts.iam.gserviceaccount.com, Ji Qiu, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
    Attention needed from Ji Qiu and Yahan Lu (LuYahan)

    Darius Mercadier voted and added 1 comment

    Votes added by Darius Mercadier

    Code-Review+1

    1 comment

    Patchset-level comments
    Darius Mercadier . resolved

    stamp

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ji Qiu
    • Yahan Lu (LuYahan)
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Id08ab7c5944135af741edf646b7632c5c235880a
    Gerrit-Change-Number: 8221145
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
    Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
    Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
    Gerrit-Attention: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
    Gerrit-Attention: Ji Qiu <qi...@iscas.ac.cn>
    Gerrit-Comment-Date: Fri, 14 Aug 2026 15:03:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages