[wasm][flags] Fully disable shared custom descriptors [v8/v8 : main]
0 views
Skip to first unread message
Matthias Liedtke (Gerrit)
1:58 PM (6 hours ago) 1:58 PM
to Jakob Kummerow, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Jakob Kummerow
Matthias Liedtke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matthias Liedtke
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
3:40 PM (4 hours ago) 3:40 PM
to Matthias Liedtke, Jakob Kummerow, V8 LUCI CQ, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke
Jakob Kummerow voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jakob Kummerow
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
File test/mjsunit/wasm/custom-descriptors-validity-shared.js
Line 1, Patchset 2 (Latest):
// Copyright 2025 the V8 project authors. All rights reserved.Jakob Kummerow . resolved
2026, but I understand if you don't think that's worth a new patch set 😊
Related details
Attention is currently required from:
- Matthias Liedtke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
3:54 PM (4 hours ago) 3:54 PM
to Matthias Liedtke, Jakob Kummerow, v8-flag...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasm][flags] Fully disable shared custom descriptors
This feature isn't just experimental, it isn't implemented.
For now, prevent this feature combination via flag implications until at
least partial support has been added.
Bug: 493179861
Change-Id: I8d8aee4890297cea0679839889c7186eab897d32
Auto-Submit: Matthias Liedtke <mlie...@chromium.org>
Reviewed-by: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Jakob Kummerow <jkum...@chromium.org>
Commit-Queue: Matthias Liedtke <mlie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105835}
Files:
- M src/flags/flag-definitions.h
- M test/mjsunit/mjsunit.status
- A test/mjsunit/wasm/custom-descriptors-validity-shared.js
- M test/mjsunit/wasm/custom-descriptors-validity.js
Change size: M
Delta: 4 files changed, 53 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jakob Kummerow
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages