api: trigger promise hook in MarkAsHandled [v8/v8 : main]

0 views
Skip to first unread message

snek (Gerrit)

unread,
4:04 AM (5 hours ago) 4:04 AM
to Leszek Swirski, Clemens Backes, v8-re...@googlegroups.com
Attention needed from Clemens Backes and Leszek Swirski

snek voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
  • Leszek Swirski
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ie5856587e89cfeea38c6adbd3d50b0f4c802428b
Gerrit-Change-Number: 7595271
Gerrit-PatchSet: 1
Gerrit-Owner: snek <sn...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: snek <sn...@chromium.org>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Feb 2026 09:03:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Leszek Swirski (Gerrit)

unread,
4:12 AM (5 hours ago) 4:12 AM
to snek, V8 LUCI CQ, Clemens Backes, v8-re...@googlegroups.com
Attention needed from Clemens Backes and snek

Leszek Swirski added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Leszek Swirski . resolved

This doesn't look compatible with existing uses of the API, e.g. at a random search I see https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/animation/animation.cc;l=2202;drc=78013f86fcae48254c2db16cd4f13bbb4c87c1f0 which explicitly uses the current behaviour to suppress the error.

Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
  • snek
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ie5856587e89cfeea38c6adbd3d50b0f4c802428b
Gerrit-Change-Number: 7595271
Gerrit-PatchSet: 1
Gerrit-Owner: snek <sn...@chromium.org>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: snek <sn...@chromium.org>
Gerrit-Attention: snek <sn...@chromium.org>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Feb 2026 09:12:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

snek (Gerrit)

unread,
4:14 AM (5 hours ago) 4:14 AM
to V8 LUCI CQ, Leszek Swirski, Clemens Backes, v8-re...@googlegroups.com
Attention needed from Clemens Backes and Leszek Swirski

snek added 1 comment

Patchset-level comments
Leszek Swirski . unresolved

This doesn't look compatible with existing uses of the API, e.g. at a random search I see https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/animation/animation.cc;l=2202;drc=78013f86fcae48254c2db16cd4f13bbb4c87c1f0 which explicitly uses the current behaviour to suppress the error.

snek

This hook is specifically emitting `v8::kPromiseHandlerAddedAfterReject`. It won't change anything about that call site.

Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
  • Leszek Swirski
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie5856587e89cfeea38c6adbd3d50b0f4c802428b
    Gerrit-Change-Number: 7595271
    Gerrit-PatchSet: 1
    Gerrit-Owner: snek <sn...@chromium.org>
    Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
    Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
    Gerrit-Reviewer: snek <sn...@chromium.org>
    Gerrit-Attention: Clemens Backes <clem...@chromium.org>
    Gerrit-Attention: Leszek Swirski <les...@chromium.org>
    Gerrit-Comment-Date: Tue, 24 Feb 2026 09:14:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Leszek Swirski <les...@chromium.org>
    unsatisfied_requirement
    open
    diffy

    snek (Gerrit)

    unread,
    4:15 AM (5 hours ago) 4:15 AM
    to V8 LUCI CQ, Leszek Swirski, Clemens Backes, v8-re...@googlegroups.com
    Attention needed from Clemens Backes and Leszek Swirski

    snek added 1 comment

    Patchset-level comments
    Leszek Swirski . unresolved

    This doesn't look compatible with existing uses of the API, e.g. at a random search I see https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/animation/animation.cc;l=2202;drc=78013f86fcae48254c2db16cd4f13bbb4c87c1f0 which explicitly uses the current behaviour to suppress the error.

    snek

    This hook is specifically emitting `v8::kPromiseHandlerAddedAfterReject`. It won't change anything about that call site.

    snek

    (also it only triggers if `!has_handler() && state() == kRejected`, which is not true for that call site)

    Gerrit-Comment-Date: Tue, 24 Feb 2026 09:15:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: snek <sn...@chromium.org>
    Comment-In-Reply-To: Leszek Swirski <les...@chromium.org>
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages