[maglev] Consider all uses for TruncatedInt32 [v8/v8 : main]
0 views
Skip to first unread message
Victor Gomes (Gerrit)
Feb 2, 2026, 5:50:17 AM (2 days ago) Feb 2
to Darius Mercadier, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Victor Gomes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Feb 3, 2026, 3:26:22 AM (yesterday) Feb 3
to Marja Hölttä, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marja Hölttä
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Marja Hölttä
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marja Hölttä (Gerrit)
Feb 3, 2026, 3:42:02 AM (yesterday) Feb 3
to Victor Gomes, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Marja Hölttä added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Marja Hölttä . resolved
drive-by comment, but I don't understand enough about this to actually tell whether this is correct or not
File test/mjsunit/maglev/regress-480568109.js
Line 14, Patchset 1 (Latest):
print(val);Marja Hölttä . unresolved
remove this to make the test quieter
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marja Hölttä (Gerrit)
Feb 3, 2026, 5:46:16 AM (23 hours ago) Feb 3
to Victor Gomes, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Marja Hölttä voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Feb 3, 2026, 7:41:53 AM (21 hours ago) Feb 3
to Marja Hölttä, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Victor Gomes voted and added 2 comments![]( "Open in Gerrit")
Votes added by Victor Gomes
| Auto-Submit | +1 |
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File test/mjsunit/maglev/regress-480568109.js
remove this to make the test quieter
Victor Gomes
I need a tagged use, so I created an empty bar() instead.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Feb 3, 2026, 8:19:36 AM (20 hours ago) Feb 3
to Marja Hölttä, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Victor Gomes voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Feb 3, 2026, 9:01:59 AM (19 hours ago) Feb 3
to Victor Gomes, Marja Hölttä, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: test/mjsunit/maglev/regress-480568109.js
Insertions: 2, Deletions: 1.
@@ -4,6 +4,7 @@
// Flags: --allow-natives-syntax --maglev-truncated-int32-phis
+function bar() {}
function foo() {
let val = 0;
@@ -11,7 +12,7 @@
1.1 >> val;
val = 1.1;
}
- print(val);
+ bar(val);
}
%PrepareFunctionForOptimization(foo);
foo();
```
Change information
Commit message:
[maglev] Consider all uses for TruncatedInt32
... not just the ones inside the loop. Since truncation
is not reversible.
Fixed: 480568109
Change-Id: I12edbdb6f3464a98226b78b29d8f65442d55dd78
Commit-Queue: Victor Gomes <victo...@chromium.org>
Auto-Submit: Victor Gomes <victo...@chromium.org>
Reviewed-by: Marja Hölttä <ma...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105063}
Files:
- M src/maglev/maglev-phi-representation-selector.cc
- A test/mjsunit/maglev/regress-480568109.js
Change size: S
Delta: 2 files changed, 24 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Marja Hölttä
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages