[maglev] Fix the latest Math.min/max fix [v8/v8 : main]
0 views
Skip to first unread message
Marja Hölttä (Gerrit)
Oct 24, 2025, 8:28:33 AM (2 days ago) Oct 24
to Leszek Swirski, V8 LUCI CQ, AyeAye, v8-re...@googlegroups.com, leszek...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski
Marja Hölttä added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Oct 24, 2025, 8:31:49 AM (2 days ago) Oct 24
to Marja Hölttä, V8 LUCI CQ, AyeAye, v8-re...@googlegroups.com, leszek...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marja Hölttä
Leszek Swirski voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Marja Hölttä
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marja Hölttä (Gerrit)
Oct 24, 2025, 8:32:10 AM (2 days ago) Oct 24
to Leszek Swirski, V8 LUCI CQ, AyeAye, v8-re...@googlegroups.com, leszek...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Marja Hölttä voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Oct 24, 2025, 9:02:58 AM (2 days ago) Oct 24
to Marja Hölttä, Leszek Swirski, AyeAye, v8-re...@googlegroups.com, leszek...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[maglev] Fix the latest Math.min/max fix
1) Unwrap the conversions
2) Add the missing folding for max
Fixed: 454364323
Bug: 454094408
Change-Id: I9a072f0cf71904e95628a2290090d7bd84119326
Reviewed-by: Leszek Swirski <les...@chromium.org>
Commit-Queue: Marja Hölttä <ma...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103345}
Files:
- M src/maglev/maglev-reducer-inl.h
- A test/mjsunit/maglev/regress-454364323.js
Change size: S
Delta: 2 files changed, 25 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Leszek Swirski
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages