[maglev] Fix the latest Math.min/max fix [v8/v8 : main]

0 views
Skip to first unread message

Marja Hölttä (Gerrit)

unread,
Oct 24, 2025, 8:28:33 AM (2 days ago) Oct 24
to Leszek Swirski, V8 LUCI CQ, AyeAye, v8-re...@googlegroups.com, leszek...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Leszek Swirski

Marja Hölttä added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Marja Hölttä . resolved

ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Leszek Swirski
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I9a072f0cf71904e95628a2290090d7bd84119326
Gerrit-Change-Number: 7079173
Gerrit-PatchSet: 1
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Attention: Leszek Swirski <les...@chromium.org>
Gerrit-Comment-Date: Fri, 24 Oct 2025 12:28:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Leszek Swirski (Gerrit)

unread,
Oct 24, 2025, 8:31:49 AM (2 days ago) Oct 24
to Marja Hölttä, V8 LUCI CQ, AyeAye, v8-re...@googlegroups.com, leszek...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Marja Hölttä

Leszek Swirski voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Marja Hölttä
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I9a072f0cf71904e95628a2290090d7bd84119326
Gerrit-Change-Number: 7079173
Gerrit-PatchSet: 1
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Attention: Marja Hölttä <ma...@chromium.org>
Gerrit-Comment-Date: Fri, 24 Oct 2025 12:31:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Marja Hölttä (Gerrit)

unread,
Oct 24, 2025, 8:32:10 AM (2 days ago) Oct 24
to Leszek Swirski, V8 LUCI CQ, AyeAye, v8-re...@googlegroups.com, leszek...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org

Marja Hölttä voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I9a072f0cf71904e95628a2290090d7bd84119326
Gerrit-Change-Number: 7079173
Gerrit-PatchSet: 1
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
Gerrit-Comment-Date: Fri, 24 Oct 2025 12:32:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Oct 24, 2025, 9:02:58 AM (2 days ago) Oct 24
to Marja Hölttä, Leszek Swirski, AyeAye, v8-re...@googlegroups.com, leszek...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
[maglev] Fix the latest Math.min/max fix

1) Unwrap the conversions
2) Add the missing folding for max
Fixed: 454364323
Bug: 454094408
Change-Id: I9a072f0cf71904e95628a2290090d7bd84119326
Reviewed-by: Leszek Swirski <les...@chromium.org>
Commit-Queue: Marja Hölttä <ma...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103345}
Files:
  • M src/maglev/maglev-reducer-inl.h
  • A test/mjsunit/maglev/regress-454364323.js
Change size: S
Delta: 2 files changed, 25 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Leszek Swirski
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I9a072f0cf71904e95628a2290090d7bd84119326
Gerrit-Change-Number: 7079173
Gerrit-PatchSet: 2
Gerrit-Owner: Marja Hölttä <ma...@chromium.org>
Gerrit-Reviewer: Leszek Swirski <les...@chromium.org>
Gerrit-Reviewer: Marja Hölttä <ma...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages