[maglev] Unwrap identities in SameValue [v8/v8 : main]

0 views
Skip to first unread message

Victor Gomes (Gerrit)

unread,
Feb 23, 2026, 10:48:34 AM (22 hours ago) Feb 23
to Olivier Flückiger, AyeAye, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Olivier Flückiger

Victor Gomes voted and added 1 comment

Votes added by Victor Gomes

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Victor Gomes . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Olivier Flückiger
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5fcc0883cf31ee39baf744fa1ee61b5f724806d3
Gerrit-Change-Number: 7595083
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Olivier Flückiger <ol...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Feb 2026 15:48:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Olivier Flückiger (Gerrit)

unread,
Feb 23, 2026, 10:54:15 AM (22 hours ago) Feb 23
to Victor Gomes, V8 LUCI CQ, AyeAye, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes

Olivier Flückiger voted and added 1 comment

Votes added by Olivier Flückiger

Code-Review+1

1 comment

Patchset-level comments
Olivier Flückiger . resolved

lgtm, thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Gomes
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5fcc0883cf31ee39baf744fa1ee61b5f724806d3
Gerrit-Change-Number: 7595083
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Attention: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Feb 2026 15:54:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Victor Gomes (Gerrit)

unread,
2:35 AM (7 hours ago) 2:35 AM
to Olivier Flückiger, V8 LUCI CQ, AyeAye, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

Victor Gomes voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5fcc0883cf31ee39baf744fa1ee61b5f724806d3
Gerrit-Change-Number: 7595083
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
Gerrit-Reviewer: Victor Gomes <victo...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Feb 2026 07:35:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
2:37 AM (6 hours ago) 2:37 AM
to Victor Gomes, Olivier Flückiger, AyeAye, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
[maglev] Unwrap identities in SameValue
Fixed: 484589689
Change-Id: I5fcc0883cf31ee39baf744fa1ee61b5f724806d3
Auto-Submit: Victor Gomes <victo...@chromium.org>
Commit-Queue: Victor Gomes <victo...@chromium.org>
Reviewed-by: Olivier Flückiger <ol...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105396}
Files:
  • M src/maglev/maglev-known-node-aspects.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Olivier Flückiger
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I5fcc0883cf31ee39baf744fa1ee61b5f724806d3
Gerrit-Change-Number: 7595083
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Gomes <victo...@chromium.org>
Gerrit-Reviewer: Olivier Flückiger <ol...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages