[wasm] Fix walking WasmLiftoffSetupFrame [v8/v8 : main]
0 views
Skip to first unread message
Jakob Kummerow (Gerrit)
Mar 10, 2026, 5:09:33 PMMar 10
to Jakob Kummerow, Clemens Backes, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Clemens Backes
Jakob Kummerow voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jakob Kummerow
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jakob Kummerow . resolved
PTAL.
No regression test because the repro we have would just run forever after the fix.
Note to platform ports teams: to determine the right constant to define, look at the spilling code in `Builtins::Generate_WasmLiftoffFrameSetup` for your platform. Any existing comments in `WasmLiftoffSetupFrameConstants` might also be helpful.
Related details
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Mar 11, 2026, 6:20:11 AMMar 11
to Jakob Kummerow, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Jakob Kummerow
Clemens Backes voted and added 2 comments![]( "Open in Gerrit")
Votes added by Clemens Backes
| Code-Review | +1 |
2 comments
Patchset-level comments
Clemens Backes . resolved
Nice, LGTM.
File src/execution/frames.h
Line 1587, Patchset 1 (Latest):
int GetDeclaredFunctionIndex() const;Clemens Backes . unresolved
As discussed, this shouldn't be needed any more. But it's a minor cleanup and can be done separately.
Related details
Attention is currently required from:
- Jakob Kummerow
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Kummerow (Gerrit)
Mar 11, 2026, 3:16:16 PMMar 11
to Jakob Kummerow, Clemens Backes, V8 LUCI CQ, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
Jakob Kummerow voted and added 2 comments![]( "Open in Gerrit")
Votes added by Jakob Kummerow
| Commit-Queue | +2 |
2 comments
Patchset-level comments
Jakob Kummerow . resolved
Thanks for the review! Landing.
File src/execution/frames.h
Line 1587, Patchset 1 (Latest):
int GetDeclaredFunctionIndex() const;Clemens Backes . resolved
As discussed, this shouldn't be needed any more. But it's a minor cleanup and can be done separately.
Jakob Kummerow
It's a little more than a cleanup: we'd have to pull the code lookup before the early return for no tagged parameters. I'll leave it as is for now.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 11, 2026, 3:17:53 PMMar 11
to Jakob Kummerow, Clemens Backes, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasm] Fix walking WasmLiftoffSetupFrame
It can happen that a Liftoff code object that just called its own
frame setup has immediately afterwards been flushed due to memory
pressure. In that case, we can't look it up by func index via the
NativeModule (because that would return nullptr); instead we must
look it up by contained PC address via the WasmCodeManager.
Fixed: 490980546
Change-Id: I448d6f35eaa9761cbfe1c852a273f240f782df84
Reviewed-by: Clemens Backes <clem...@chromium.org>
Commit-Queue: Jakob Kummerow <jkum...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105744}
Files:
- M src/execution/arm/frame-constants-arm.h
- M src/execution/arm64/frame-constants-arm64.h
- M src/execution/frames.cc
- M src/execution/frames.h
- M src/execution/ia32/frame-constants-ia32.h
- M src/execution/x64/frame-constants-x64.h
Change size: S
Delta: 6 files changed, 14 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Clemens Backes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ji Qiu (Gerrit)
Mar 12, 2026, 2:30:35 AMMar 12
to Yahan Lu (LuYahan), V8 LUCI CQ, v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Yahan Lu (LuYahan)
Ji Qiu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ji Qiu
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Yahan Lu (LuYahan)
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yahan Lu (LuYahan) (Gerrit)
Mar 12, 2026, 3:30:45 AMMar 12
to Ji Qiu, V8 LUCI CQ, v8-re...@googlegroups.com, v8-risc...@chromium.org
Yahan Lu (LuYahan) voted![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 12, 2026, 5:49:52 AMMar 12
to Yahan Lu (LuYahan), Ji Qiu, v8-re...@googlegroups.com, v8-risc...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[riscv][wasm] Fix walking WasmLiftoffSetupFrame
Port commit dec5f6bdbe683eb74f7908310ac9a742d057181a
Bug:490980546
Change-Id: I7e8b4c78536f7b1c070302ce04e9ce67d401d42c
Auto-Submit: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Reviewed-by: Ji Qiu <qi...@iscas.ac.cn>
Commit-Queue: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Commit-Queue: Ji Qiu <qi...@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#105750}
Files:
- M src/execution/riscv/frame-constants-riscv.h
Change size: XS
Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ji Qiu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liu Yu (Gerrit)
Mar 12, 2026, 11:08:16 PMMar 12
to Zhao Jiazhong, v8-loonga...@chromium.org, v8-mip...@googlegroups.com, v8-re...@googlegroups.com
Attention needed from Zhao Jiazhong
Liu Yu voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Zhao Jiazhong
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zhao Jiazhong (Gerrit)
Mar 12, 2026, 11:24:40 PMMar 12
to Liu Yu, v8-loonga...@chromium.org, v8-mip...@googlegroups.com, v8-re...@googlegroups.com
Attention needed from Liu Yu
Zhao Jiazhong voted and added 1 comment![]( "Open in Gerrit")
Votes added by Zhao Jiazhong
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Liu Yu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 13, 2026, 12:01:36 AMMar 13
to Liu Yu, Zhao Jiazhong, v8-loonga...@chromium.org, v8-mip...@googlegroups.com, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[loong64][mips64][wasm] Fix walking WasmLiftoffSetupFrame
Port commit dec5f6bdbe683eb74f7908310ac9a742d057181a
Port commit 42ae3ed711b2a9a4a78f33415dbdf1f1246dc3f8
Bug: 490980546
Change-Id: I82d2df66bb363bda8f77be8cd50be5f0b8718ff2
Auto-Submit: Liu Yu <li...@loongson.cn>
Reviewed-by: Zhao Jiazhong <zhaojia...@loongson.cn>
Commit-Queue: Zhao Jiazhong <zhaojia...@loongson.cn>
Cr-Commit-Position: refs/heads/main@{#105778}
Files:
- M src/builtins/mips64/builtins-mips64.cc
- M src/execution/loong64/frame-constants-loong64.h
- M src/execution/mips64/frame-constants-mips64.h
Change size: M
Delta: 3 files changed, 52 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Zhao Jiazhong
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages