[wasm][shared] Shared Wasm objects in GotoIfCannotBeHeldWeakly [v8/v8 : main]

0 views

Skip to first unread message

Manos Koukoutos (Gerrit)

unread,

Mar 10, 2026, 9:58:19 AMMar 10

to Matthias Liedtke, v8-re...@googlegroups.com

Attention needed from Matthias Liedtke

Manos Koukoutos voted and added 1 comment

Votes added by Manos Koukoutos

Commit-Queue

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Manos Koukoutos . resolved

Matthias, PTAL.

Open in Gerrit

Related details

Attention is currently required from:

Matthias Liedtke

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Matthias Liedtke (Gerrit)

unread,

Mar 10, 2026, 10:07:39 AMMar 10

to Manos Koukoutos, V8 LUCI CQ, v8-re...@googlegroups.com

Attention needed from Manos Koukoutos

Matthias Liedtke voted and added 4 comments

Votes added by Matthias Liedtke

Code-Review

4 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Matthias Liedtke . resolved

LGTM with a few comments

Commit Message

Line 7, Patchset 1 (Latest):[wasm][shared] Shared Wasm objects in GotoIfCannotBeHeldWeakly

Matthias Liedtke . unresolved

What's with them? This message misses something imo. 😊

Maybe
```suggestion
[wasm][shared] Add handling of shared Wasm objects in GotoIfCannotBeHeldWeakly
```

File src/builtins/builtins-collections-gen.cc

Line 495, Patchset 1 (Latest):

  GotoIf(InstanceTypeEqual(instance_type, WASM_ARRAY_TYPE),
         &check_not_in_shared_space);
  GotoIf(InstanceTypeEqual(instance_type, WASM_STRUCT_TYPE),
         &check_not_in_shared_space);

Matthias Liedtke . unresolved

For performance reasons, maybe it would be faster to use `FIRST_WASM_OBJECT_TYPE` and `LAST_WASM_OBJECT_TYPE`, similarly to what we are doing in `IsDataRefMap` in `wasm-lowering-reducer.h`, so we only have a single comparison?

Line 504, Patchset 1 (Latest):

  TNode<IntPtrT> page_flags = LoadMemoryChunkFlags(CAST(obj));
  GotoIf(WordNotEqual(
             WordAnd(page_flags,
                     IntPtrConstant(MemoryChunk::IN_WRITABLE_SHARED_SPACE)),
             IntPtrConstant(0)),

Matthias Liedtke . unresolved

This part already appears a few tiems in `code-stub-assembler.cc`. Can we add a utility function on the assembler for this and reuse it here?

Open in Gerrit

Related details

Attention is currently required from:

Manos Koukoutos

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages