[base] Use clang::lifetimebound in Small{Map,Vector} [v8/v8 : main]
0 views
Skip to first unread message
Maksim Ivanov (Gerrit)
Mar 10, 2026, 9:15:00 AMMar 10
to Igor Sheludko, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Igor Sheludko
Maksim Ivanov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Maksim Ivanov
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Mar 10, 2026, 9:25:44 AMMar 10
to Maksim Ivanov, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Maksim Ivanov
Igor Sheludko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Maksim Ivanov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
Mar 10, 2026, 9:43:19 AMMar 10
to Igor Sheludko, V8 LUCI CQ, v8-re...@googlegroups.com
Maksim Ivanov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Mar 10, 2026, 9:45:15 AMMar 10
to Maksim Ivanov, Igor Sheludko, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[base] Use clang::lifetimebound in Small{Map,Vector}
Adopt the [[clang::lifetimebound]] attribute in base::SmallMap and
base::SmallVector, to help Clang catch memory safety issues in the code
that uses pointers/references/iterators to these.Bug: 482994758
Change-Id: Icd0ba1498a02f04653bb497b7a21a9e567ab82cf
Commit-Queue: Maksim Ivanov <em...@chromium.org>
Reviewed-by: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105704}
Files:
- M src/base/small-map.h
- M src/base/small-vector.h
Change size: M
Delta: 2 files changed, 47 insertions(+), 38 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Igor Sheludko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages