Remove external references for allocation space top/limit [v8/v8 : main]
0 views
Skip to first unread message
Clemens Backes (Gerrit)
Sep 4, 2025, 8:50:05 AM (3 days ago) Sep 4
to Darius Mercadier, Dominik Inführ, V8 LUCI CQ, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Clemens Backes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Sep 4, 2025, 9:59:51 AM (3 days ago) Sep 4
to Clemens Backes, Dominik Inführ, V8 LUCI CQ, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Clemens Backes
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Sep 5, 2025, 3:39:28 AM (2 days ago) Sep 5
to Clemens Backes, Dominik Inführ, V8 LUCI CQ, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Clemens Backes
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Darius Mercadier . resolved
Looks like my +1 was lost in a rebase. I assume that nothing changed, so I'm just re-applying it without re-reviewing (since the patchset 1-3 and 2-3 diffs are broken because of the rebase)
Related details
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Sep 5, 2025, 3:41:50 AM (2 days ago) Sep 5
to Darius Mercadier, Dominik Inführ, V8 LUCI CQ, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Clemens Backes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Darius Mercadier . resolved
Looks like my +1 was lost in a rebase. I assume that nothing changed, so I'm just re-applying it without re-reviewing (since the patchset 1-3 and 2-3 diffs are broken because of the rebase)
Clemens Backes
Thanks for taking another look already!
I would have pinged you when the previous CLs got LGTMs. Otherwise there's always a risk that this needs another rebase.
This CL actually got a lot simpler. All the changes to the macro assemblers are not needed any more after https://crrev.com/c/6916875, because we can reference the top and limit fields directly now.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Sep 5, 2025, 3:43:36 AM (2 days ago) Sep 5
to Clemens Backes, Dominik Inführ, V8 LUCI CQ, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Clemens Backes
Darius Mercadier added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Darius Mercadier . resolved
Clemens BackesLooks like my +1 was lost in a rebase. I assume that nothing changed, so I'm just re-applying it without re-reviewing (since the patchset 1-3 and 2-3 diffs are broken because of the rebase)
Thanks for taking another look already!
I would have pinged you when the previous CLs got LGTMs. Otherwise there's always a risk that this needs another rebase.This CL actually got a lot simpler. All the changes to the macro assemblers are not needed any more after https://crrev.com/c/6916875, because we can reference the top and limit fields directly now.
Darius Mercadier
Ah, I was unpiling incoming reviews, and somehow I was in the attention set for this CL so I assumed that I had missed a ping :D
Well, feel free to ping when you lose the +1 again :D
Related details
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Sep 5, 2025, 12:26:14 PM (2 days ago) Sep 5
to Darius Mercadier, Dominik Inführ, V8 LUCI CQ, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Clemens Backes voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Sep 5, 2025, 12:28:04 PM (2 days ago) Sep 5
to Darius Mercadier, Dominik Inführ, V8 LUCI CQ, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
Clemens Backes voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Sep 5, 2025, 12:59:32 PM (2 days ago) Sep 5
to Clemens Backes, Darius Mercadier, Dominik Inführ, leszek...@chromium.org, v8-mip...@googlegroups.com, v8-ppc...@googlegroups.com, v8-re...@googlegroups.com, v8-risc...@chromium.org, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Remove external references for allocation space top/limit
Some uses disappeared with https://crrev.com/c/6909719, others can be
replaced by loading via the new `IsolateFieldId`s introduced in
https://crrev.com/c/6916875.
R=dmerc...@chromium.org
CC=dinf...@chromium.org
Bug: 442745065
Change-Id: Id7e3e493e9578fe6e2423a86903cb331f5064f42
Commit-Queue: Clemens Backes <clem...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102289}
Files:
- M src/codegen/code-stub-assembler.cc
- M src/codegen/external-reference.cc
- M src/codegen/external-reference.h
- M src/maglev/arm/maglev-assembler-arm.cc
- M src/maglev/arm64/maglev-assembler-arm64.cc
- M src/maglev/maglev-assembler.h
- M src/maglev/x64/maglev-assembler-x64.cc
Change size: M
Delta: 7 files changed, 20 insertions(+), 48 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages