[test] Add syncpoint test for externalization during JIT [v8/v8 : main]
0 views
Skip to first unread message
Maksim Ivanov (Gerrit)
Jul 24, 2026, 9:18:26 AM (20 hours ago) Jul 24
to Darius Mercadier, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Darius Mercadier
Maksim Ivanov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 10 (Latest):
Maksim Ivanov . resolved
WDYT about such a test? Trying to add test coverage for some "potentially interesting" race situations.
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Jul 24, 2026, 9:53:09 AM (19 hours ago) Jul 24
to Maksim Ivanov, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Maksim Ivanov
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Maksim Ivanov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
Jul 24, 2026, 9:55:01 AM (19 hours ago) Jul 24
to Darius Mercadier, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Maksim Ivanov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
Jul 24, 2026, 9:55:41 AM (19 hours ago) Jul 24
to Michael Achenbach, Darius Mercadier, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Michael Achenbach
Maksim Ivanov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Maksim Ivanov
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Maksim Ivanov . resolved
+machenbach@ to double-check what I'm doing at mjsunit.status and testrunner. Thank you!
Related details
Attention is currently required from:
- Michael Achenbach
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Achenbach (Gerrit)
Jul 24, 2026, 10:38:43 AM (18 hours ago) Jul 24
to Maksim Ivanov, Darius Mercadier, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Attention needed from Maksim Ivanov
Michael Achenbach voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michael Achenbach
| Code-Review | +1 |
1 comment
File tools/testrunner/local/variants.py
Line 210, Patchset 10 (Latest):
"--no-jitless",Michael Achenbach . resolved
This is not wrong... I was hoping though that the no-versions of the flags listed in each variant would be incompatible by default. Guess they are not... but we could change that to avoid also listing those...
Related details
Attention is currently required from:
- Maksim Ivanov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Ivanov (Gerrit)
Jul 24, 2026, 11:01:07 AM (18 hours ago) Jul 24
to Michael Achenbach, Darius Mercadier, v8-s...@luci-project-accounts.iam.gserviceaccount.com, v8-re...@googlegroups.com
Maksim Ivanov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Maksim Ivanov
| Auto-Submit | +1 |
| Commit-Queue | +2 |
Michael Achenbach . resolved
This is not wrong... I was hoping though that the no-versions of the flags listed in each variant would be incompatible by default. Guess they are not... but we could change that to avoid also listing those...
Maksim Ivanov
Ack - Yeah I was wondering about this, but it seemed that people tend to just skip particular tests instead.
OK, let me give it a try for a generic no-version handling in a follow-up CL! Thanks.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 24, 2026, 11:03:52 AM (18 hours ago) Jul 24
to Maksim Ivanov, Michael Achenbach, Darius Mercadier, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
10 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[test] Add syncpoint test for externalization during JIT
Add a synchronization point based test to verify the scenario when a
string gets externalized concurrently with a background JIT logic trying
to use it in a concatenation.
Verified triggers a TSan report if the string access guard is
temporarily commented out.
Bug: 514998642
Change-Id: I4e50f170966a00e4c3e4301fb9b70947e83340af
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Auto-Submit: Maksim Ivanov <em...@google.com>
Reviewed-by: Michael Achenbach <mache...@chromium.org>
Commit-Queue: Maksim Ivanov <em...@google.com>
Cr-Commit-Position: refs/heads/main@{#108871}
Files:
- A test/mjsunit/compiler/concurrent-string-ext-seq.js
- M test/mjsunit/mjsunit.status
- M tools/testrunner/local/variants.py
Change size: M
Delta: 3 files changed, 63 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Achenbach, +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages