[tools] Do collect build-ids when profiling with linux-perf [v8/v8 : main]

0 views
Skip to first unread message

Camillo Bruni (Gerrit)

unread,
4:26 AM (7 hours ago) 4:26 AM
to Jakob Linke, v8-re...@googlegroups.com
Attention needed from Jakob Linke

Camillo Bruni added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Camillo Bruni . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Linke
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If6efcc572e0c2dfd70e48613866ab5930a74a0a7
Gerrit-Change-Number: 7456551
Gerrit-PatchSet: 1
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Attention: Jakob Linke <jgr...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 09:26:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Camillo Bruni (Gerrit)

unread,
4:26 AM (7 hours ago) 4:26 AM
to Jakob Linke, v8-re...@googlegroups.com
Attention needed from Jakob Linke

Camillo Bruni voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jakob Linke
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If6efcc572e0c2dfd70e48613866ab5930a74a0a7
Gerrit-Change-Number: 7456551
Gerrit-PatchSet: 1
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Attention: Jakob Linke <jgr...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 09:26:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jakob Linke (Gerrit)

unread,
4:28 AM (7 hours ago) 4:28 AM
to Camillo Bruni, v8-re...@googlegroups.com
Attention needed from Camillo Bruni

Jakob Linke voted and added 2 comments

Votes added by Jakob Linke

Code-Review+1

2 comments

Patchset-level comments
Jakob Linke . resolved

Thanks!

Commit Message
Line 7, Patchset 1 (Latest):[tools] Do collect build-ids when profiling with linux-perf
Jakob Linke . unresolved

```suggestion
[tools] Do not collect build-ids when profiling with linux-perf
```

Open in Gerrit

Related details

Attention is currently required from:
  • Camillo Bruni
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: If6efcc572e0c2dfd70e48613866ab5930a74a0a7
Gerrit-Change-Number: 7456551
Gerrit-PatchSet: 1
Gerrit-Owner: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-Reviewer: Jakob Linke <jgr...@chromium.org>
Gerrit-Attention: Camillo Bruni <cbr...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Jan 2026 09:28:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages