[riscv] Fix sp handling in MacroAssembler::LeaveFrame [v8/v8 : main]

0 views
Skip to first unread message

Vivian Wang (Gerrit)

unread,
Feb 3, 2026, 3:59:50 AM (yesterday) Feb 3
to Rezvan Mahdavi Hezaveh, Yahan Lu (LuYahan), Ji Qiu, Levi Zim, V8 LUCI CQ, Han Gao (Revy), v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Ji Qiu and Rezvan Mahdavi Hezaveh

Vivian Wang added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Vivian Wang . resolved

This is my first CL to v8. Please take a look. Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Ji Qiu
  • Rezvan Mahdavi Hezaveh
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ief0836032ada7942e89f081f7605f61632c4d414
Gerrit-Change-Number: 7540554
Gerrit-PatchSet: 2
Gerrit-Owner: Vivian Wang <wangr...@iscas.ac.cn>
Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Reviewer: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Gerrit-Reviewer: Vivian Wang <wangr...@iscas.ac.cn>
Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-CC: Han Gao (Revy) <raben...@gmail.com>
Gerrit-CC: Levi Zim <rswor...@outlook.com>
Gerrit-Attention: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Gerrit-Attention: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Comment-Date: Tue, 03 Feb 2026 08:59:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Ji Qiu (Gerrit)

unread,
Feb 3, 2026, 5:09:33 AM (23 hours ago) Feb 3
to Vivian Wang, Rezvan Mahdavi Hezaveh, Yahan Lu (LuYahan), Levi Zim, V8 LUCI CQ, Han Gao (Revy), v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Rezvan Mahdavi Hezaveh and Vivian Wang

Ji Qiu voted

Code-Review+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Rezvan Mahdavi Hezaveh
  • Vivian Wang
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ief0836032ada7942e89f081f7605f61632c4d414
Gerrit-Change-Number: 7540554
Gerrit-PatchSet: 2
Gerrit-Owner: Vivian Wang <wangr...@iscas.ac.cn>
Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Reviewer: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Gerrit-Reviewer: Vivian Wang <wangr...@iscas.ac.cn>
Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-CC: Han Gao (Revy) <raben...@gmail.com>
Gerrit-CC: Levi Zim <rswor...@outlook.com>
Gerrit-Attention: Vivian Wang <wangr...@iscas.ac.cn>
Gerrit-Attention: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Feb 2026 10:09:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Rezvan Mahdavi Hezaveh (Gerrit)

unread,
Feb 3, 2026, 6:18:32 PM (10 hours ago) Feb 3
to Vivian Wang, Ji Qiu, Yahan Lu (LuYahan), Levi Zim, V8 LUCI CQ, Han Gao (Revy), v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Vivian Wang

Rezvan Mahdavi Hezaveh voted and added 1 comment

Votes added by Rezvan Mahdavi Hezaveh

Code-Review+1

1 comment

Patchset-level comments
Rezvan Mahdavi Hezaveh . resolved

Stamp the AUTHORS file.

Open in Gerrit

Related details

Attention is currently required from:
  • Vivian Wang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ief0836032ada7942e89f081f7605f61632c4d414
Gerrit-Change-Number: 7540554
Gerrit-PatchSet: 2
Gerrit-Owner: Vivian Wang <wangr...@iscas.ac.cn>
Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Reviewer: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Gerrit-Reviewer: Vivian Wang <wangr...@iscas.ac.cn>
Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-CC: Han Gao (Revy) <raben...@gmail.com>
Gerrit-CC: Levi Zim <rswor...@outlook.com>
Gerrit-Attention: Vivian Wang <wangr...@iscas.ac.cn>
Gerrit-Comment-Date: Tue, 03 Feb 2026 23:18:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Vivian Wang (Gerrit)

unread,
Feb 3, 2026, 6:20:19 PM (10 hours ago) Feb 3
to Rezvan Mahdavi Hezaveh, Ji Qiu, Yahan Lu (LuYahan), Levi Zim, V8 LUCI CQ, Han Gao (Revy), v8-re...@googlegroups.com, v8-risc...@chromium.org

Vivian Wang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ief0836032ada7942e89f081f7605f61632c4d414
Gerrit-Change-Number: 7540554
Gerrit-PatchSet: 2
Gerrit-Owner: Vivian Wang <wangr...@iscas.ac.cn>
Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Reviewer: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Gerrit-Reviewer: Vivian Wang <wangr...@iscas.ac.cn>
Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-CC: Han Gao (Revy) <raben...@gmail.com>
Gerrit-CC: Levi Zim <rswor...@outlook.com>
Gerrit-Comment-Date: Tue, 03 Feb 2026 23:20:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Yahan Lu (LuYahan) (Gerrit)

unread,
Feb 3, 2026, 7:43:18 PM (9 hours ago) Feb 3
to Vivian Wang, Rezvan Mahdavi Hezaveh, Ji Qiu, Levi Zim, V8 LUCI CQ, Han Gao (Revy), v8-re...@googlegroups.com, v8-risc...@chromium.org
Attention needed from Vivian Wang

Yahan Lu (LuYahan) voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Vivian Wang
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ief0836032ada7942e89f081f7605f61632c4d414
Gerrit-Change-Number: 7540554
Gerrit-PatchSet: 2
Gerrit-Owner: Vivian Wang <wangr...@iscas.ac.cn>
Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Reviewer: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Gerrit-Reviewer: Vivian Wang <wangr...@iscas.ac.cn>
Gerrit-Reviewer: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Gerrit-CC: Han Gao (Revy) <raben...@gmail.com>
Gerrit-CC: Levi Zim <rswor...@outlook.com>
Gerrit-Attention: Vivian Wang <wangr...@iscas.ac.cn>
Gerrit-Comment-Date: Wed, 04 Feb 2026 00:43:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Feb 3, 2026, 7:44:48 PM (9 hours ago) Feb 3
to Vivian Wang, Yahan Lu (LuYahan), Rezvan Mahdavi Hezaveh, Ji Qiu, Levi Zim, Han Gao (Revy), v8-re...@googlegroups.com, v8-risc...@chromium.org

V8 LUCI CQ submitted the change

Change information

Commit message:
[riscv] Fix sp handling in MacroAssembler::LeaveFrame

Keep sp <= fp to ensure that data right above fp doesn't get clobbered
by an inopportune signal and its handler.

Such clobbering can happen in e.g. Node.js when JIT-compiled code is
interrupted by a SIGCHLD handler.
Bug: None
Change-Id: Ief0836032ada7942e89f081f7605f61632c4d414
Reviewed-by: Ji Qiu <qi...@iscas.ac.cn>
Commit-Queue: Yahan Lu (LuYahan) <ya...@iscas.ac.cn>
Reviewed-by: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105069}
Files:
  • M AUTHORS
  • M src/codegen/riscv/macro-assembler-riscv.cc
Change size: XS
Delta: 2 files changed, 3 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Rezvan Mahdavi Hezaveh, +1 by Ji Qiu
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ief0836032ada7942e89f081f7605f61632c4d414
Gerrit-Change-Number: 7540554
Gerrit-PatchSet: 3
Gerrit-Owner: Vivian Wang <wangr...@iscas.ac.cn>
Gerrit-Reviewer: Ji Qiu <qi...@iscas.ac.cn>
Gerrit-Reviewer: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages