[wasm][revec] Add default path for all unsupported operations [v8/v8 : main]

[Chen, Yolanda (Gerrit)]

Attention needed from Jakob Kummerow and Manos Koukoutos

Chen, Yolanda added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Chen, Yolanda . resolved

Hi Jakob and Manos, PTAL, Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Jakob Kummerow
• Manos Koukoutos

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I2e21659fc83e925441e824de3cb7a624684adc34

Gerrit-Change-Number: 7600963

Gerrit-PatchSet: 2

Gerrit-Owner: Chen, Yolanda <yoland...@intel.com>

Gerrit-Reviewer: Chen, Yolanda <yoland...@intel.com>

Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>

Gerrit-Reviewer: Manos Koukoutos <mano...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Manos Koukoutos <mano...@chromium.org>

Gerrit-Attention: Jakob Kummerow <jkum...@chromium.org>

Gerrit-Comment-Date: Tue, 24 Feb 2026 07:09:35 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Jakob Kummerow (Gerrit)]

Attention needed from Chen, Yolanda and Manos Koukoutos

Jakob Kummerow voted and added 1 comment

Votes added by Jakob Kummerow

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Jakob Kummerow . resolved

I'm OK with this. The benefit of the previous approach was that we'd learn about all the instructions that can show up there, which might point out some that should have been handled but were forgotten. That said, the specific purpose of the function in question seems to make it safe enough to just return `false` for any possibly-forgotten opcode, so avoiding the `UNREACHABLE()` crash is a convincing intention.

Open in Gerrit

Related details

Attention is currently required from:

• Chen, Yolanda
• Manos Koukoutos

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I2e21659fc83e925441e824de3cb7a624684adc34

Gerrit-Change-Number: 7600963

Gerrit-PatchSet: 2

Gerrit-Owner: Chen, Yolanda <yoland...@intel.com>

Gerrit-Reviewer: Chen, Yolanda <yoland...@intel.com>

Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>

Gerrit-Reviewer: Manos Koukoutos <mano...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Manos Koukoutos <mano...@chromium.org>

Gerrit-Attention: Chen, Yolanda <yoland...@intel.com>

Gerrit-Comment-Date: Tue, 24 Feb 2026 10:42:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Manos Koukoutos (Gerrit)]

Attention needed from Chen, Yolanda

Manos Koukoutos voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Chen, Yolanda

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I2e21659fc83e925441e824de3cb7a624684adc34

Gerrit-Change-Number: 7600963

Gerrit-PatchSet: 2

Gerrit-Owner: Chen, Yolanda <yoland...@intel.com>

Gerrit-Reviewer: Chen, Yolanda <yoland...@intel.com>

Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>

Gerrit-Reviewer: Manos Koukoutos <mano...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Chen, Yolanda <yoland...@intel.com>

Gerrit-Comment-Date: Tue, 24 Feb 2026 10:57:42 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chen, Yolanda (Gerrit)]

Chen, Yolanda voted and added 1 comment

Votes added by Chen, Yolanda

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Jakob Kummerow . resolved

I'm OK with this. The benefit of the previous approach was that we'd learn about all the instructions that can show up there, which might point out some that should have been handled but were forgotten. That said, the specific purpose of the function in question seems to make it safe enough to just return `false` for any possibly-forgotten opcode, so avoiding the `UNREACHABLE()` crash is a convincing intention.

Chen, Yolanda

Yes, we've got to know some of the unsupported operations and they may still be handled later. I've added a trace to catch them up if we need to debug any revectorization failures.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I2e21659fc83e925441e824de3cb7a624684adc34

Gerrit-Change-Number: 7600963

Gerrit-PatchSet: 2

Gerrit-Owner: Chen, Yolanda <yoland...@intel.com>

Gerrit-Reviewer: Chen, Yolanda <yoland...@intel.com>

Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>

Gerrit-Reviewer: Manos Koukoutos <mano...@chromium.org>

Gerrit-CC: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Comment-Date: Tue, 24 Feb 2026 11:11:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Jakob Kummerow <jkum...@chromium.org>

[V8 LUCI CQ (Gerrit)]

V8 LUCI CQ submitted the change

Change information

Commit message:

[wasm][revec] Add default path for all unsupported operations

There're still more operations (StructGet or ArrayGet) supporting
Simd128 output, even though they are not classified as SIMD operation.
Add a default path for all unsupported to avoid unreachable crash.

DISABLE_SPELLCHECKER

Fixed: 485814576

Bug: 42202660

Change-Id: I2e21659fc83e925441e824de3cb7a624684adc34

Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7600963

Reviewed-by: Manos Koukoutos <mano...@chromium.org>

Reviewed-by: Jakob Kummerow <jkum...@chromium.org>

Commit-Queue: Chen, Yolanda <yoland...@intel.com>

Cr-Commit-Position: refs/heads/main@{#105407}

Files:

• M src/compiler/turboshaft/wasm-revec-reducer.cc

Change size: S

Delta: 1 file changed, 7 insertions(+), 12 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Jakob Kummerow, +1 by Manos Koukoutos

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: v8/v8

Gerrit-Branch: main

Gerrit-Change-Id: I2e21659fc83e925441e824de3cb7a624684adc34

Gerrit-Change-Number: 7600963

Gerrit-PatchSet: 3

Gerrit-Owner: Chen, Yolanda <yoland...@intel.com>

Gerrit-Reviewer: Chen, Yolanda <yoland...@intel.com>

Gerrit-Reviewer: Jakob Kummerow <jkum...@chromium.org>

Gerrit-Reviewer: Manos Koukoutos <mano...@chromium.org>

Gerrit-Reviewer: V8 LUCI CQ <v8-s...@luci-project-accounts.iam.gserviceaccount.com>