[turboshaft] Raise the JS partial-unrolling loop size limit to 64 [v8/v8 : main]
0 views
Skip to first unread message
Victor Gomes (Gerrit)
Aug 14, 2026, 9:27:38 AM (yesterday) Aug 14
to Marco Vitale, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Marco Vitale
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Marco Vitale
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marco Vitale (Gerrit)
Aug 14, 2026, 10:39:45 AM (yesterday) Aug 14
to Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Victor Gomes
Marco Vitale added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Marco Vitale . resolved
Maybe a stupid question but, is there any way to do this just for Turbolev, or the frontend information is completely lost on Turboshaft?
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Aug 14, 2026, 10:40:55 AM (yesterday) Aug 14
to v8-s...@luci-project-accounts.iam.gserviceaccount.com, Marco Vitale, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Marco Vitale
Victor Gomes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Marco Vitale . resolved
Maybe a stupid question but, is there any way to do this just for Turbolev, or the frontend information is completely lost on Turboshaft?
Victor Gomes
Why would you want to do just for TLV? We will delete Turbofan in the next months...
Related details
Attention is currently required from:
- Marco Vitale
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marco Vitale (Gerrit)
Aug 14, 2026, 10:43:25 AM (yesterday) Aug 14
to Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Victor Gomes
Marco Vitale added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Marco Vitale . resolved
Victor GomesMaybe a stupid question but, is there any way to do this just for Turbolev, or the frontend information is completely lost on Turboshaft?
Why would you want to do just for TLV? We will delete Turbofan in the next months...
Marco Vitale
I'm scared about compilation time for something that might not be needed on turbofan... If you are ok with it / think it is not a problem, lgtm 😊
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Aug 14, 2026, 10:56:24 AM (yesterday) Aug 14
to v8-s...@luci-project-accounts.iam.gserviceaccount.com, Marco Vitale, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Marco Vitale
Victor Gomes added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Marco Vitale . resolved
Victor GomesMaybe a stupid question but, is there any way to do this just for Turbolev, or the frontend information is completely lost on Turboshaft?
Marco VitaleWhy would you want to do just for TLV? We will delete Turbofan in the next months...
I'm scared about compilation time for something that might not be needed on turbofan... If you are ok with it / think it is not a problem, lgtm 😊
Attention is currently required from:
- Marco Vitale
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marco Vitale (Gerrit)
Aug 14, 2026, 10:59:43 AM (yesterday) Aug 14
to Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Victor Gomes
Marco Vitale voted and added 1 comment![]( "Open in Gerrit")
Votes added by Marco Vitale
| Code-Review | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
Aug 14, 2026, 2:14:07 PM (yesterday) Aug 14
to Marco Vitale, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, v8-re...@googlegroups.com
Victor Gomes voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Aug 14, 2026, 2:17:01 PM (yesterday) Aug 14
to Victor Gomes, Marco Vitale, dmercadi...@chromium.org, v8-re...@googlegroups.com
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[turboshaft] Raise the JS partial-unrolling loop size limit to 64
Turbolev-built graphs reach LoopUnrolling before any DCE and carry a few
dead ops per loop (unused tagged phi chains and their retagging inputs),
so hot loops land just above the 50-op limit that the same loop built by
the TurboFan frontend stays under. Also trace op_count and has_any_call
in the unrolling analyzer.
Bug: 42204525
Change-Id: I003a2101b941770f0298a768bf8af1e5ad479921
Commit-Queue: Victor Gomes <victo...@chromium.org>
Reviewed-by: Marco Vitale <mrc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#109265}
Files:
- M src/compiler/turboshaft/loop-unrolling-reducer.cc
- M src/compiler/turboshaft/loop-unrolling-reducer.h
Change size: XS
Delta: 2 files changed, 4 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Marco Vitale
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages