[sandbox] Harden BigIntLiteralToDecimal... [v8/v8 : main]
Jakob Kummerow (Gerrit)
Jakob Kummerow voted and added 5 comments![]( "Open in Gerrit")
Votes added by Jakob Kummerow
| Auto-Submit | +1 |
| Commit-Queue | +1 |
5 comments
Toon: PTAL, since you are conveniently an OWNER of both `parsing` and `sandbox`.
Samuel: FYI.
for (uint32_t i = 0; i < chunk_chars_; i++) {All of the changes in this file are just cleanup.
CHECK(char_count_ < std::numeric_limits<uint32_t>::max() / 2);This is not a tight bound for avoiding OOB writes into `out_`, but it doesn't hurt to protect the multiplication on line 340 in the _next_ call to this constructor against overflow.
I don't feel strongly about this; we could drop it or downgrade it to a `DCHECK`; but this code is sufficiently non-performance-critical that we can easily afford a `CHECK` here.
SandboxChars out(SandboxAllocArray<uint8_t>(1));I was really tempted to craft a little helper for inline/on-stack storage here; but if we want to actually sandboxify stuff, we can't avoid this.
auto [decimal, length] = BigIntLiteralToDecimal(local_isolate_, literal);Drive-by performance tuning: by passing along the `length` here (which the producer of the string knows anyway), we avoid a `strlen()` call in the `char*`-consuming `GetOneByteString` overload.
Related details
- Toon Verwaest
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |