Replace `std::set` with `absl::flat_hash_set`. [v8/v8 : main]
0 views
Skip to first unread message
Matthias Liedtke (Gerrit)
Feb 2, 2026, 12:01:50 PM (2 days ago) Feb 2
to Jeffrey Yu, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Jeffrey Yu
Matthias Liedtke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Matthias Liedtke
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthias Liedtke (Gerrit)
Feb 2, 2026, 12:02:50 PM (2 days ago) Feb 2
to Jeffrey Yu, Olivier Flückiger, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Jeffrey Yu and Olivier Flückiger
Matthias Liedtke added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Matthias Liedtke . resolved
@ol...@chromium.org: PTAL, this needs a second reviewer and you're probably closer to any `Intl` work than I am. 😊
Related details
Attention is currently required from:
- Jeffrey Yu
- Olivier Flückiger
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivier Flückiger (Gerrit)
Feb 3, 2026, 9:13:49 AM (19 hours ago) Feb 3
to Jeffrey Yu, Shane Carr (Chromium), Matthias Liedtke, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Jeffrey Yu and Shane Carr (Chromium)
Olivier Flückiger added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Olivier Flückiger . resolved
Hi, thanks for this patch. I am a bit worried though that this is just blindly applying a pattern. Do you have a usecase where the performance of the locale constructor is relevant? And if you have one, did you measure this CL?
Is this function really a the bottleneck in the locale constructor? And if it is, given how small valid variant strings are and how few `-` we expect, I am pretty sure that a linear search would be faster.
I ran this CL against a microbench and didn't see any improvement.
```
let t = performance.now();
for (let i = 0; i < 100000; ++i) {
new Intl.Locale("sl-rozaj-biske");
new Intl.Locale("sl", { variants: "rozaj-biske" });
}
console.log(performance.now() - t);
```
Related details
Attention is currently required from:
- Jeffrey Yu
- Shane Carr (Chromium)
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shane Carr (Chromium) (Gerrit)
Feb 3, 2026, 9:45:53 AM (19 hours ago) Feb 3
to Jeffrey Yu, Frank Tang, Olivier Flückiger, Matthias Liedtke, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Frank Tang and Jeffrey Yu
Shane Carr (Chromium) added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Shane Carr (Chromium) . resolved
Usually it's Frank who reviews these PRs.
Related details
Attention is currently required from:
- Frank Tang
- Jeffrey Yu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages