[api] Allow v8::String::WriteOneByteV2() for two-byte strings [v8/v8 : main]
0 views
Skip to first unread message
Igor Sheludko (Gerrit)
Sep 26, 2025, 6:19:21 AM (yesterday) Sep 26
to Michael Lippautz, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Igor Sheludko voted and added 2 comments![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Auto-Submit | +1 |
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File src/api/api.cc
Line 5941, Patchset 1 (Parent):
DCHECK(IsOneByte());Igor Sheludko . unresolved
The underlying i::String::WriteToFlat() used for both old and new Api does support this case.
Related details
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Lippautz (Gerrit)
Sep 26, 2025, 6:24:57 AM (yesterday) Sep 26
to Igor Sheludko, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Igor Sheludko
Michael Lippautz voted![]( "Open in Gerrit")
Attention is currently required from:
- Igor Sheludko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Sheludko (Gerrit)
Sep 26, 2025, 6:25:45 AM (yesterday) Sep 26
to Michael Lippautz, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Michael Lippautz
Igor Sheludko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Igor Sheludko
| Commit-Queue | +2 |
1 comment
File src/api/api.cc
Line 5941, Patchset 1 (Parent):
DCHECK(IsOneByte());Igor Sheludko . resolved
The underlying i::String::WriteToFlat() used for both old and new Api does support this case.
Attention is currently required from:
- Michael Lippautz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Sep 26, 2025, 6:55:52 AM (yesterday) Sep 26
to Igor Sheludko, Michael Lippautz, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[api] Allow v8::String::WriteOneByteV2() for two-byte strings
... as it was allowed by the old WriteOneByte() Api.
This CLs add missing tests for this case.
Bug: 373485796
Change-Id: I0768ce3e8c59ac1c6b88d0a291a18cd84e18e6ba
Reviewed-by: Michael Lippautz <mlip...@chromium.org>
Auto-Submit: Igor Sheludko <ish...@chromium.org>
Commit-Queue: Igor Sheludko <ish...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102789}
Files:
- M src/api/api.cc
- M test/cctest/test-api.cc
Change size: S
Delta: 2 files changed, 34 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michael Lippautz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages