[for-of-performance] Add expectations test [v8/v8 : main]
0 views
Skip to first unread message
Leszek Swirski (Gerrit)
Sep 4, 2025, 7:52:06 AM (3 days ago) Sep 4
to Rezvan Mahdavi Hezaveh, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Rezvan Mahdavi Hezaveh
Leszek Swirski added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Leszek Swirski . resolved
Hey, I added functionality to the golden files to allow specifying arbitrary flags, so that you can define expectations tests with your flag. Here's an example, you can add more snippets if you want.
Related details
Attention is currently required from:
- Rezvan Mahdavi Hezaveh
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rezvan Mahdavi Hezaveh (Gerrit)
Sep 4, 2025, 3:57:41 PM (3 days ago) Sep 4
to Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Rezvan Mahdavi Hezaveh voted and added 1 comment![]( "Open in Gerrit")
Votes added by Rezvan Mahdavi Hezaveh
| Code-Review | +1 |
1 comment
Patchset-level comments
Leszek Swirski . resolved
Hey, I added functionality to the golden files to allow specifying arbitrary flags, so that you can define expectations tests with your flag. Here's an example, you can add more snippets if you want.
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rezvan Mahdavi Hezaveh (Gerrit)
Sep 4, 2025, 4:29:36 PM (3 days ago) Sep 4
to Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Rezvan Mahdavi Hezaveh voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Sep 4, 2025, 4:30:57 PM (3 days ago) Sep 4
to Leszek Swirski, Rezvan Mahdavi Hezaveh, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[for-of-performance] Add expectations test
Add a new golden file which enables the flag, and can track changes to
the emitted optimized bytecode.
Bug: 408061015
Change-Id: Iae87bdace42954275a1febe2eb88eaa9e575f573
Commit-Queue: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Reviewed-by: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#102254}
Files:
- A test/unittests/interpreter/bytecode_expectations/ForOfOptimization.golden
Change size: M
Delta: 1 file changed, 82 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rezvan Mahdavi Hezaveh
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages