[maglev] Track initializing context stores [v8/v8 : main]
0 views
Skip to first unread message
Toon Verwaest (Gerrit)
7:03 AM (17 hours ago) 7:03 AM
to Victor Gomes, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Toon Verwaest voted and added 1 comment![]( "Open in Gerrit")
Votes added by Toon Verwaest
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Gomes (Gerrit)
7:08 AM (17 hours ago) 7:08 AM
to Toon Verwaest, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Toon Verwaest
Victor Gomes voted and added 2 comments![]( "Open in Gerrit")
Votes added by Victor Gomes
| Code-Review | +1 |
2 comments
Patchset-level comments
Victor Gomes . resolved
LGTM!
File src/maglev/maglev-known-node-aspects.h
Line 646, Patchset 1 (Latest):
auto& target_map =
(offset == Context::OffsetOfElementAt(Context::PREVIOUS_INDEX))
? loaded_context_constants_
: loaded_context_slots_;
Victor Gomes . unresolved
Idea: we could have kInitialzingToContextConstant or something, and then if Context::PREVIOUS_INDEX, use constant?
Related details
Attention is currently required from:
- Toon Verwaest
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Toon Verwaest (Gerrit)
7:31 AM (16 hours ago) 7:31 AM
to Victor Gomes, V8 LUCI CQ, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Toon Verwaest voted and added 1 comment![]( "Open in Gerrit")
Votes added by Toon Verwaest
| Commit-Queue | +2 |
1 comment
File src/maglev/maglev-known-node-aspects.h
Line 646, Patchset 1 (Latest):
auto& target_map =
(offset == Context::OffsetOfElementAt(Context::PREVIOUS_INDEX))
? loaded_context_constants_
: loaded_context_slots_;
Victor Gomes . resolved
Idea: we could have kInitialzingToContextConstant or something, and then if Context::PREVIOUS_INDEX, use constant?
Toon Verwaest
Let's try this later; and by extension look at the scope-info to see which slots are immutable. That makes the change a bit more complex though, so I prefer to land this separately.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
7:44 AM (16 hours ago) 7:44 AM
to Toon Verwaest, Victor Gomes, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[maglev] Track initializing context stores
This will allow the maglev optimizer to find parent contexts and other
values in allocated contexts.
Bug: 474179451
Change-Id: Ib08c64688498792e96d2220cf7ed3bde22a8021a
Auto-Submit: Toon Verwaest <verw...@chromium.org>
Commit-Queue: Toon Verwaest <verw...@chromium.org>
Reviewed-by: Victor Gomes <victo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104594}
Files:
- M src/maglev/maglev-graph-builder.cc
- M src/maglev/maglev-graph-builder.h
- M src/maglev/maglev-ir.h
- M src/maglev/maglev-known-node-aspects.h
- A test/mjsunit/regress/regress-474179451.js
Change size: M
Delta: 5 files changed, 59 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Victor Gomes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages