[base64] Fix use of ResizableArrayBuffers [v8/v8 : main]
2 views
Skip to first unread message
Rezvan Mahdavi Hezaveh (Gerrit)
Oct 24, 2025, 4:31:55 PM (4 days ago) Oct 24
to Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Leszek Swirski
Rezvan Mahdavi Hezaveh voted and added 1 comment![]( "Open in Gerrit")
Votes added by Rezvan Mahdavi Hezaveh
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Rezvan Mahdavi Hezaveh . resolved
I cannot see anything in the spec text preventing the usage of this methods on Uint8Array views of ResizableArrayBuffers (https://tc39.es/proposal-arraybuffer-base64/spec/). Looks like we missed it before. PTAL. Thanks!
Related details
Attention is currently required from:
- Leszek Swirski
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Oct 27, 2025, 5:12:37 AM (yesterday) Oct 27
to Rezvan Mahdavi Hezaveh, Marja Hölttä, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Marja Hölttä and Rezvan Mahdavi Hezaveh
Leszek Swirski added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Leszek Swirski . resolved
Seems reasonable to me, but I'd like marja to take a look to make sure that this is guarding against length changes correctly (since this is stage 3 and we want to make sure there aren't any spec bugs too)
Related details
Attention is currently required from:
- Marja Hölttä
- Rezvan Mahdavi Hezaveh
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Marja Hölttä (Gerrit)
Oct 27, 2025, 5:25:55 AM (yesterday) Oct 27
to Rezvan Mahdavi Hezaveh, Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Marja Hölttä and Rezvan Mahdavi Hezaveh
Marja Hölttä voted and added 1 comment![]( "Open in Gerrit")
Votes added by Marja Hölttä
| Code-Review | +1 |
1 comment
Patchset-level comments
Marja Hölttä . resolved
LGTM; looks like these methods don't do any fancy input conversions (e.g., the string param has to be a string and won't be converted to a string) or have other hooks which could call into user code which would then resize the buffer.
Related details
Attention is currently required from:
- Marja Hölttä
- Rezvan Mahdavi Hezaveh
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rezvan Mahdavi Hezaveh (Gerrit)
Oct 27, 2025, 6:34:08 AM (yesterday) Oct 27
to Marja Hölttä, Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Marja Hölttä
Rezvan Mahdavi Hezaveh added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Rezvan Mahdavi Hezaveh . resolved
Thanks you both for the review and confirming it.
Related details
Attention is currently required from:
- Marja Hölttä
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rezvan Mahdavi Hezaveh (Gerrit)
Oct 27, 2025, 6:34:18 AM (yesterday) Oct 27
to Marja Hölttä, Leszek Swirski, V8 LUCI CQ, v8-re...@googlegroups.com
Attention needed from Marja Hölttä
Rezvan Mahdavi Hezaveh voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Marja Hölttä
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Oct 27, 2025, 7:11:01 AM (yesterday) Oct 27
to Rezvan Mahdavi Hezaveh, Marja Hölttä, Leszek Swirski, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[base64] Fix use of ResizableArrayBuffers
Uint8Array views of ResizableArrayBuffers should be acceptable
as receivers in methods of base64 proposal.
Bug: 454630441
Change-Id: I3da1b66ce8b19cbf7ca29fcb175533122ba029d5
Reviewed-by: Marja Hölttä <ma...@chromium.org>
Commit-Queue: Rezvan Mahdavi Hezaveh <rez...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103359}
Files:
- M src/builtins/builtins-typed-array.cc
- A test/mjsunit/harmony/regress/regress-454630441.js
Change size: S
Delta: 2 files changed, 42 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Marja Hölttä
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages