[wasmfx] Fix allocation during stack switch [v8/v8 : main]
0 views
Skip to first unread message
Thibaud Michaud (Gerrit)
Dec 9, 2025, 7:57:56 AM12/9/25
to Clemens Backes, v8-re...@googlegroups.com, was...@google.com
Attention needed from Clemens Backes
Thibaud Michaud voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thibaud Michaud
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Clemens Backes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Clemens Backes (Gerrit)
Dec 9, 2025, 8:22:52 AM12/9/25
to Thibaud Michaud, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Attention needed from Thibaud Michaud
Clemens Backes voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Thibaud Michaud
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thibaud Michaud (Gerrit)
Dec 9, 2025, 8:25:36 AM12/9/25
to Clemens Backes, V8 LUCI CQ, v8-re...@googlegroups.com, was...@google.com
Thibaud Michaud voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Dec 9, 2025, 8:35:20 AM12/9/25
to Thibaud Michaud, Clemens Backes, v8-re...@googlegroups.com, was...@google.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[wasmfx] Fix allocation during stack switch
Tagged values in the stack-allocated argument buffer are not tracked by
the GC, so there must not be any GC until the buffer is unpacked by the
target stack.
In the suspend instruction, the new continuation object was mistakenly
allocated after initializing the argument buffer which could cause a GC.
Move it up.
R=clem...@chromium.org
Fixed: 466948626
Change-Id: Ic97320d1c70d196b78f85e2aa1806a2dade8dd2c
Commit-Queue: Thibaud Michaud <thib...@chromium.org>
Reviewed-by: Clemens Backes <clem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104198}
Files:
- M src/wasm/turboshaft-graph-interface.cc
- M test/mjsunit/mjsunit.status
Change size: S
Delta: 2 files changed, 6 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Clemens Backes
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages