[heap] Put --managed_zone_memory behind --future [v8/v8 : main]

0 views
Skip to first unread message

Michael Lippautz (Gerrit)

unread,
Dec 9, 2025, 9:52:31 AM12/9/25
to Dominik Inführ, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Dominik Inführ

Michael Lippautz voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dominik Inführ
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id1ddefe37139a047b112c43001233bedcc20cc23
Gerrit-Change-Number: 7242303
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Dominik Inführ <dinf...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:52:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dominik Inführ (Gerrit)

unread,
Dec 9, 2025, 9:57:25 AM12/9/25
to Michael Lippautz, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz

Dominik Inführ voted and added 1 comment

Votes added by Dominik Inführ

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Dominik Inführ . resolved

Thanks, LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id1ddefe37139a047b112c43001233bedcc20cc23
Gerrit-Change-Number: 7242303
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:57:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Dec 9, 2025, 10:58:53 AM12/9/25
to Dominik Inführ, V8 LUCI CQ, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

Michael Lippautz voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id1ddefe37139a047b112c43001233bedcc20cc23
Gerrit-Change-Number: 7242303
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 15:58:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Dec 9, 2025, 11:02:24 AM12/9/25
to Michael Lippautz, Dominik Inführ, Hannes Payer, mlippau...@chromium.org, v8-flag...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[heap] Put --managed_zone_memory behind --future

The feature is already enabled on field trial for many months and being
run through Finch. Putting it behind --future will also get more fuzzing
coverage.

Drive-by:
- Rename page_pool_timeout -> memory_pool_timeout.
- Remove large_page_pool from future as it is enabled by default.
Bug: 409953791
Change-Id: Id1ddefe37139a047b112c43001233bedcc20cc23
Reviewed-by: Dominik Inführ <dinf...@chromium.org>
Auto-Submit: Michael Lippautz <mlip...@chromium.org>
Commit-Queue: Michael Lippautz <mlip...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#104208}
Files:
  • M src/flags/flag-definitions.h
  • M src/heap/heap.cc
  • M src/heap/memory-pool.cc
  • M test/unittests/heap/pool-unittest.cc
Change size: S
Delta: 4 files changed, 9 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dominik Inführ
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Id1ddefe37139a047b112c43001233bedcc20cc23
Gerrit-Change-Number: 7242303
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Lippautz <mlip...@chromium.org>
Gerrit-Reviewer: Dominik Inführ <dinf...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages