[maglev] Bound the stack frame size of generated code [v8/v8 : main]
0 views
Skip to first unread message
Victor Gomes (Gerrit)
Jul 24, 2026, 8:30:07 AM (20 hours ago) Jul 24
to Darius Mercadier, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Victor Gomes voted and added 1 comment![]( "Open in Gerrit")
Votes added by Victor Gomes
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Darius Mercadier (Gerrit)
Jul 24, 2026, 10:26:52 AM (19 hours ago) Jul 24
to Victor Gomes, v8-s...@luci-project-accounts.iam.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Victor Gomes
Darius Mercadier voted and added 1 comment![]( "Open in Gerrit")
Votes added by Darius Mercadier
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Victor Gomes
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
v8-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 24, 2026, 10:28:51 AM (19 hours ago) Jul 24
to Victor Gomes, Darius Mercadier, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
v8-s...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[maglev] Bound the stack frame size of generated code
Maglev grows its frame with a single stack pointer decrement, before
FunctionEntryStackCheck runs, so frames have to stay within the size.
Maglev now bails out on max_optimized_bytecode_size like TurboFan.
It also bails out if the number of stack slots is bigger than
an OS page.
Fixed: 536945254
Change-Id: I7355d2257bebcf62b756a7f57c327d4f27677685
Auto-Submit: Victor Gomes <victo...@chromium.org>
Reviewed-by: Darius Mercadier <dmerc...@chromium.org>
Commit-Queue: Darius Mercadier <dmerc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108869}
Files:
- M src/codegen/compiler.cc
- M src/maglev/maglev-compiler.cc
- M src/maglev/maglev-concurrent-dispatcher.cc
- M src/maglev/maglev-concurrent-dispatcher.h
- A test/mjsunit/maglev/regress-536945254.js
Change size: M
Delta: 5 files changed, 89 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Darius Mercadier
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages