Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +1 |
LGTM!
if (!CanSpeculateCall()) return {};
Nit: What's the value if the args.count() == 0? We can return it before the CanSpeculate condition.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
thx!
if (!CanSpeculateCall()) return {};
Nit: What's the value if the args.count() == 0? We can return it before the CanSpeculate condition.
As discussed IRL, we'd still need to check that receiver is a string in that case -> that would clutter the code and prob the benefit is not that high -> not doing it.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[maglev] String.p.slice(-1) optimization: add a missing String check
Even if we check that we're calling the correct slice function, the receiver is not necessarily a string.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |