[arm64][wasm] Use LaneSizeField for SIMD AllTrue, Pmin & Pmax instructions [v8/v8 : main]

0 views
Skip to first unread message

Emily Boarer (Gerrit)

unread,
Dec 9, 2025, 9:21:21 AM12/9/25
to Matthias Liedtke, V8 LUCI CQ, Sam Parker-Haynes, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Matthias Liedtke

Emily Boarer voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Matthias Liedtke
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I6f0325d1f3fca89259ecf89d7f9f9f42758d7cc3
Gerrit-Change-Number: 7241575
Gerrit-PatchSet: 1
Gerrit-Owner: Emily Boarer <emily....@arm.com>
Gerrit-Reviewer: Emily Boarer <emily....@arm.com>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Attention: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 14:21:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Matthias Liedtke (Gerrit)

unread,
Dec 9, 2025, 10:49:47 AM12/9/25
to Emily Boarer, V8 LUCI CQ, Sam Parker-Haynes, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Emily Boarer

Matthias Liedtke voted and added 1 comment

Votes added by Matthias Liedtke

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Matthias Liedtke . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Emily Boarer
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I6f0325d1f3fca89259ecf89d7f9f9f42758d7cc3
Gerrit-Change-Number: 7241575
Gerrit-PatchSet: 1
Gerrit-Owner: Emily Boarer <emily....@arm.com>
Gerrit-Reviewer: Emily Boarer <emily....@arm.com>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Attention: Emily Boarer <emily....@arm.com>
Gerrit-Comment-Date: Tue, 09 Dec 2025 15:49:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sam Parker-Haynes (Gerrit)

unread,
Dec 10, 2025, 3:36:12 AM12/10/25
to Emily Boarer, Matthias Liedtke, V8 LUCI CQ, dmercadi...@chromium.org, v8-re...@googlegroups.com
Attention needed from Emily Boarer

Sam Parker-Haynes voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Emily Boarer
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I6f0325d1f3fca89259ecf89d7f9f9f42758d7cc3
Gerrit-Change-Number: 7241575
Gerrit-PatchSet: 1
Gerrit-Owner: Emily Boarer <emily....@arm.com>
Gerrit-Reviewer: Emily Boarer <emily....@arm.com>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
Gerrit-Attention: Emily Boarer <emily....@arm.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 08:36:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

V8 LUCI CQ (Gerrit)

unread,
Dec 10, 2025, 3:39:24 AM12/10/25
to Emily Boarer, Sam Parker-Haynes, Matthias Liedtke, dmercadi...@chromium.org, v8-re...@googlegroups.com

V8 LUCI CQ submitted the change

Change information

Commit message:
[arm64][wasm] Use LaneSizeField for SIMD AllTrue, Pmin & Pmax instructions

Free up opcode space by encoding size in LaneSizeField
Change-Id: I6f0325d1f3fca89259ecf89d7f9f9f42758d7cc3
Auto-Submit: Emily Boarer <emily....@arm.com>
Reviewed-by: Sam Parker-Haynes <sam.p...@arm.com>
Reviewed-by: Matthias Liedtke <mlie...@chromium.org>
Commit-Queue: Sam Parker-Haynes <sam.p...@arm.com>
Cr-Commit-Position: refs/heads/main@{#104220}
Files:
  • M src/compiler/backend/arm64/code-generator-arm64.cc
  • M src/compiler/backend/arm64/instruction-codes-arm64.h
  • M src/compiler/backend/arm64/instruction-scheduler-arm64.cc
  • M src/compiler/backend/arm64/instruction-selector-arm64.cc
Change size: M
Delta: 4 files changed, 53 insertions(+), 101 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Sam Parker-Haynes, +1 by Matthias Liedtke
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I6f0325d1f3fca89259ecf89d7f9f9f42758d7cc3
Gerrit-Change-Number: 7241575
Gerrit-PatchSet: 2
Gerrit-Owner: Emily Boarer <emily....@arm.com>
Gerrit-Reviewer: Emily Boarer <emily....@arm.com>
Gerrit-Reviewer: Matthias Liedtke <mlie...@chromium.org>
Gerrit-Reviewer: Sam Parker-Haynes <sam.p...@arm.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages