[compiler] Inline Array.prototype.sort in Maglev and Turbofan [v8/v8 : main]
0 views
Skip to first unread message
Jakob Linke (Gerrit)
Apr 2, 2026, 6:40:23 AM (4 days ago) Apr 2
to Darius Mercadier, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Jakob Linke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jakob Linke
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4:
Jakob Linke . resolved
Ptal! Vibe-check for this please, just quick look over the reductions and the force-inline mechanism would be great.
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Apr 2, 2026, 6:43:31 AM (4 days ago) Apr 2
to Darius Mercadier, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Jakob Linke added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jakob Linke . resolved
Ptal! Vibe-check for this please, just quick look over the reductions and the force-inline mechanism would be great.
Jakob Linke
Note the TF reduction is less powerful - seems okay as it'll be deprecated soon.
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 3, 2026, 2:51:57 AM (3 days ago) Apr 3
to Jakob Linke, Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier and Jakob Linke
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/177ef14b090000
Related details
Attention is currently required from:
- Darius Mercadier
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 3, 2026, 2:52:25 AM (3 days ago) Apr 3
to Jakob Linke, Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier and Jakob Linke
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12b76417090000
Related details
Attention is currently required from:
- Darius Mercadier
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 3, 2026, 3:01:15 AM (3 days ago) Apr 3
to Jakob Linke, Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier and Jakob Linke
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job linux-r350-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/12576813090000
Related details
Attention is currently required from:
- Darius Mercadier
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Apr 3, 2026, 4:47:44 AM (3 days ago) Apr 3
to Darius Mercadier, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Jakob Linke added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jakob Linke . resolved
Jakob LinkePtal! Vibe-check for this please, just quick look over the reductions and the force-inline mechanism would be great.
Note the TF reduction is less powerful - seems okay as it'll be deprecated soon.
Jakob Linke
force-inline removed, wasn't helping.
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 3, 2026, 8:12:44 AM (3 days ago) Apr 3
to Jakob Linke, Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier and Jakob Linke
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job linux-r350-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/17fc3e23090000
Related details
Attention is currently required from:
- Darius Mercadier
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 3, 2026, 8:15:47 AM (3 days ago) Apr 3
to Jakob Linke, Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier and Jakob Linke
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/13b10fcf090000
Related details
Attention is currently required from:
- Darius Mercadier
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
Apr 3, 2026, 8:15:53 AM (3 days ago) Apr 3
to Jakob Linke, Darius Mercadier, V8 LUCI CQ, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier and Jakob Linke
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m4-mini-perf/jetstream-main.crossbench complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/10e82040890000
Related details
Attention is currently required from:
- Darius Mercadier
- Jakob Linke
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jakob Linke (Gerrit)
Apr 3, 2026, 9:02:05 AM (3 days ago) Apr 3
to Darius Mercadier, V8 LUCI CQ, chrom...@appspot.gserviceaccount.com, dmercadi...@chromium.org, leszek...@chromium.org, v8-re...@googlegroups.com, verwaes...@chromium.org, victorgo...@chromium.org
Attention needed from Darius Mercadier
Jakob Linke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jakob Linke
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 12 (Latest):
Jakob Linke . resolved
Setting autosubmit since I'm ooo next week - just in case everything lgty for a first land (plus maybe followups).
Related details
Attention is currently required from:
- Darius Mercadier
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages