[maglev] disable Phi untagging [v8/v8 : main]

0 views
Skip to first unread message

Darius Mercadier (Gerrit)

unread,
Mar 10, 2026, 12:51:44 PMMar 10
to Michael Lippautz, V8 LUCI CQ, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Michael Lippautz

Darius Mercadier voted and added 1 comment

Votes added by Darius Mercadier

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Darius Mercadier . resolved

PTAL! :)

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I98a4884b5374fad9ac98df0ab57c4203a1ce8403
Gerrit-Change-Number: 7653638
Gerrit-PatchSet: 1
Gerrit-Owner: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Mar 2026 16:51:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Mar 10, 2026, 12:53:48 PMMar 10
to Darius Mercadier, V8 LUCI CQ, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Darius Mercadier

Michael Lippautz voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Darius Mercadier
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: I98a4884b5374fad9ac98df0ab57c4203a1ce8403
Gerrit-Change-Number: 7653638
Gerrit-PatchSet: 1
Gerrit-Owner: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Mar 2026 16:53:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
Mar 10, 2026, 1:02:56 PMMar 10
to Darius Mercadier, V8 LUCI CQ, v8-flag...@chromium.org, v8-re...@googlegroups.com
Attention needed from Darius Mercadier

Michael Lippautz voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Darius Mercadier
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I98a4884b5374fad9ac98df0ab57c4203a1ce8403
    Gerrit-Change-Number: 7653638
    Gerrit-PatchSet: 2
    Gerrit-Owner: Darius Mercadier <dmerc...@chromium.org>
    Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Attention: Darius Mercadier <dmerc...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Mar 2026 17:02:52 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    V8 LUCI CQ (Gerrit)

    unread,
    Mar 10, 2026, 1:49:51 PMMar 10
    to Darius Mercadier, Michael Lippautz, v8-flag...@chromium.org, v8-re...@googlegroups.com

    V8 LUCI CQ submitted the change

    Change information

    Commit message:
    [maglev] disable Phi untagging

    There are currently a bit too many issues with Phi untagging; let's
    disable it by default until we get things under control.
    Bug: 491410818
    Change-Id: I98a4884b5374fad9ac98df0ab57c4203a1ce8403
    Reviewed-by: Michael Lippautz <mlip...@chromium.org>
    Commit-Queue: Michael Lippautz <mlip...@chromium.org>
    Commit-Queue: Darius Mercadier <dmerc...@chromium.org>
    Auto-Submit: Darius Mercadier <dmerc...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#105711}
    Files:
    • M src/flags/flag-definitions.h
    • M test/mjsunit/turbolev/regress-490450922-3.js
    Change size: S
    Delta: 2 files changed, 7 insertions(+), 3 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Michael Lippautz
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: I98a4884b5374fad9ac98df0ab57c4203a1ce8403
    Gerrit-Change-Number: 7653638
    Gerrit-PatchSet: 3
    Gerrit-Owner: Darius Mercadier <dmerc...@chromium.org>
    Gerrit-Reviewer: Darius Mercadier <dmerc...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages